summaryrefslogtreecommitdiff
path: root/src/arch/x86
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2019-02-10 20:14:57 +0100
committerNico Huber <nico.h@gmx.de>2019-02-12 22:43:21 +0000
commit540a66404591ef41e2581df01647e5788ef0c808 (patch)
treec08429942ccd65c2744e7ca89272285be36d2e07 /src/arch/x86
parentf751aee9268a8fe1840873ae72ed06a1cfeebf5e (diff)
cpu/x86/mtrr: Fix _FROM_4G_TOP() macro
This macro was unnecessarily complex. Trying to avoid an overflow for unknown reasons, and instead shifted the result into the sign bit in C. Using a plain number literal that forces C to use an adequate integer type seems to be safe. We start with 0xffffffff, subtract `x` and add 1 again. Turned out to be a common pattern and can't overflow for any positive 32-bit `x`. Change-Id: Ibb0c5b88a6e42d3ef2990196a5b99ace90ea8ee8 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/31322 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/arch/x86')
0 files changed, 0 insertions, 0 deletions