summaryrefslogtreecommitdiff
path: root/src/arch/x86/include
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-02-06 19:47:11 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-02-08 15:49:48 +0000
commitb6969db5c2313b60dcfe0c318c06e5b97780e880 (patch)
treef11c6db6a4a38617fc3b39630b64b75abbc0707e /src/arch/x86/include
parente1a84db3e0aa2cd77a299bd86ba23dd0e3e9c038 (diff)
soc/amd/picasso/soc_util: use cpuid_match
Now that there is a cpuid_match function, we can use it instead of doing basically the same thing manually. In the functions is_fam17_1x and is_fam17_2x both the stepping number and the lower nibble of the model number are masked out. To avoid having magic constants in the code, introduce the CPUID_ALL_STEPPINGS_AND_BASE_MODELS_MASK definition. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72860 Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/arch/x86/include')
-rw-r--r--src/arch/x86/include/arch/cpu.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index cd8f8b4c97..a0a5840f78 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -121,8 +121,9 @@ struct device;
((model) & 0xf) << 4 | \
((stepping) & 0xf) << 0)
-#define CPUID_EXACT_MATCH_MASK 0xffffffff
-#define CPUID_ALL_STEPPINGS_MASK 0xfffffff0
+#define CPUID_EXACT_MATCH_MASK 0xffffffff
+#define CPUID_ALL_STEPPINGS_MASK 0xfffffff0
+#define CPUID_ALL_STEPPINGS_AND_BASE_MODELS_MASK 0xffffff00
static inline bool cpuid_match(uint32_t a, uint32_t b, uint32_t mask)
{