diff options
| author | Shelley Chen <shchen@google.com> | 2018-04-26 13:52:30 -0700 |
|---|---|---|
| committer | Shelley Chen <shchen@google.com> | 2018-05-02 20:44:24 +0000 |
| commit | a0603397740165cfa13a250851f0213e9035cd5e (patch) | |
| tree | 28c962d0a1c818680a77889b807786827d3346d7 /src/arch/x86/acpi_device.c | |
| parent | 77034fa7d4402aab9eef84fc652b0493a2024026 (diff) | |
src/drivers: Add reset/enable/stop_off_ms variables to ACPI devices
Some touchscreens need to adhere to certain timings during the power
off sequence as well as during the power on sequence. Adding
reset_off_delay_ms, enable_off_delay_ms, and stop_off_delay_ms to
accommodate these devices.
BUG=b:78311818
BRANCH=None
TEST=./util/abuild/abuild -p none -t google/poppy -x -a
Change-Id: Idb4a5dbe56eee4749d2f2b514e92c28fb2c6078f
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://review.coreboot.org/25882
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/arch/x86/acpi_device.c')
| -rw-r--r-- | src/arch/x86/acpi_device.c | 52 |
1 files changed, 29 insertions, 23 deletions
diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index 31e59eaf66..c8d313e037 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -469,15 +469,12 @@ void acpi_device_write_spi(const struct acpi_spi *spi) } /* PowerResource() with Enable and/or Reset control */ -void acpi_device_add_power_res( - struct acpi_gpio *reset, unsigned int reset_delay_ms, - struct acpi_gpio *enable, unsigned int enable_delay_ms, - struct acpi_gpio *stop, unsigned int stop_delay_ms) +void acpi_device_add_power_res(const struct acpi_power_res_params *params) { static const char *power_res_dev_states[] = { "_PR0", "_PR3" }; - unsigned int reset_gpio = reset->pins[0]; - unsigned int enable_gpio = enable->pins[0]; - unsigned int stop_gpio = stop->pins[0]; + unsigned int reset_gpio = params->reset_gpio->pins[0]; + unsigned int enable_gpio = params->enable_gpio->pins[0]; + unsigned int stop_gpio = params->stop_gpio->pins[0]; if (!reset_gpio && !enable_gpio && !stop_gpio) return; @@ -492,32 +489,41 @@ void acpi_device_add_power_res( /* Method (_ON, 0, Serialized) */ acpigen_write_method_serialized("_ON", 0); if (reset_gpio) - acpigen_enable_tx_gpio(reset); + acpigen_enable_tx_gpio(params->reset_gpio); if (enable_gpio) { - acpigen_enable_tx_gpio(enable); - if (enable_delay_ms) - acpigen_write_sleep(enable_delay_ms); + acpigen_enable_tx_gpio(params->enable_gpio); + if (params->enable_delay_ms) + acpigen_write_sleep(params->enable_delay_ms); } if (reset_gpio) { - acpigen_disable_tx_gpio(reset); - if (reset_delay_ms) - acpigen_write_sleep(reset_delay_ms); + acpigen_disable_tx_gpio(params->reset_gpio); + if (params->reset_delay_ms) + acpigen_write_sleep(params->reset_delay_ms); } if (stop_gpio) { - acpigen_disable_tx_gpio(stop); - if (stop_delay_ms) - acpigen_write_sleep(stop_delay_ms); + acpigen_disable_tx_gpio(params->stop_gpio); + if (params->stop_delay_ms) + acpigen_write_sleep(params->stop_delay_ms); } acpigen_pop_len(); /* _ON method */ /* Method (_OFF, 0, Serialized) */ acpigen_write_method_serialized("_OFF", 0); - if (stop_gpio) - acpigen_enable_tx_gpio(stop); - if (reset_gpio) - acpigen_enable_tx_gpio(reset); - if (enable_gpio) - acpigen_disable_tx_gpio(enable); + if (stop_gpio) { + acpigen_enable_tx_gpio(params->stop_gpio); + if (params->stop_off_delay_ms) + acpigen_write_sleep(params->stop_off_delay_ms); + } + if (reset_gpio) { + acpigen_enable_tx_gpio(params->reset_gpio); + if (params->reset_off_delay_ms) + acpigen_write_sleep(params->reset_off_delay_ms); + } + if (enable_gpio) { + acpigen_disable_tx_gpio(params->enable_gpio); + if (params->enable_off_delay_ms) + acpigen_write_sleep(params->enable_off_delay_ms); + } acpigen_pop_len(); /* _OFF method */ acpigen_pop_len(); /* PowerResource PRIC */ |