diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2021-07-23 10:21:48 -0600 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-07-26 07:29:16 +0000 |
| commit | 474781b2703de37ea7a484fd4cdfde5103e48d01 (patch) | |
| tree | fa7238b182dd7014de388b3be4bcf611e67b7449 /src/arch/arm | |
| parent | a2d83c68a3ea6f2017fa9eabda72dfbafae0fc37 (diff) | |
arch/{arm,ppc64,riscv}: Remove cpu_info
The structure and function are not currently used or implemented. x86 is
the only arch that currently implements it. It is currently used for
COOP_MULTITASKING and mp_init.
Keeping around the unused definitions leads to confusion.
BUG=b:179699789
TEST=none
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I0775ef03168f7f9c41b1b05cb8f12724d0458ba5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56572
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'src/arch/arm')
| -rw-r--r-- | src/arch/arm/Makefile.inc | 1 | ||||
| -rw-r--r-- | src/arch/arm/cpu.c | 19 | ||||
| -rw-r--r-- | src/arch/arm/include/armv7/arch/cpu.h | 1 |
3 files changed, 0 insertions, 21 deletions
diff --git a/src/arch/arm/Makefile.inc b/src/arch/arm/Makefile.inc index 63367bb2c0..b18b137252 100644 --- a/src/arch/arm/Makefile.inc +++ b/src/arch/arm/Makefile.inc @@ -106,7 +106,6 @@ ifeq ($(CONFIG_ARCH_RAMSTAGE_ARM),y) ramstage-y += stages.c ramstage-y += div0.c -ramstage-$(CONFIG_COOP_MULTITASKING) += cpu.c ramstage-y += eabi_compat.c ramstage-y += boot.c ramstage-y += tables.c diff --git a/src/arch/arm/cpu.c b/src/arch/arm/cpu.c deleted file mode 100644 index 75816d3fc0..0000000000 --- a/src/arch/arm/cpu.c +++ /dev/null @@ -1,19 +0,0 @@ -/* SPDX-License-Identifier: BSD-3-Clause */ - -#include <arch/cpu.h> -#include <commonlib/helpers.h> - -/* Return the CPU struct which is at the high memory address of the stack. - */ -struct cpu_info *cpu_info(void) -{ -#error "This is BROKEN! ARM stacks are currently not guaranteed to be " \ - "STACK_SIZE-aligned in any way. If you ever plan to revive this " \ - "feature, make sure you add the proper assertions " \ - "(and maybe consider revising the whole thing to work closer to what " \ - "arm64 is doing now)." - uintptr_t addr = ALIGN_UP((uintptr_t)__builtin_frame_address(0), - CONFIG_STACK_SIZE); - addr -= sizeof(struct cpu_info); - return (void *)addr; -} diff --git a/src/arch/arm/include/armv7/arch/cpu.h b/src/arch/arm/include/armv7/arch/cpu.h index af79344836..3f1f1ae811 100644 --- a/src/arch/arm/include/armv7/arch/cpu.h +++ b/src/arch/arm/include/armv7/arch/cpu.h @@ -75,5 +75,4 @@ static inline void set_system_mode(void) asm volatile("msr cpsr_c, %0" :: "r"(0x1f | 0xc0)); } -struct cpu_info *cpu_info(void); #endif /* __ARCH_CPU_H__ */ |