diff options
| author | Julius Werner <jwerner@chromium.org> | 2015-02-19 14:43:59 -0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2015-04-21 08:22:19 +0200 |
| commit | 1f60f971fc89ef841e81b978964b38278d597b1d (patch) | |
| tree | 3132eaa707a12a8ad90765f875e4dc7026f71e9a /src/arch/arm64 | |
| parent | d21a329866a1299b180f8b14b6c73bee3d754e57 (diff) | |
arm(64): Change write32() argument order to match x86
This patch changes the argument order for the (now temporarily unused)
write32() accessor macro (and equivalents for other lengths) from
(value, address) to (address, value) in order to conform with the
equivalent on x86. Also removes one remaining use of write32() on ARM
that slipped through since coccinelle doesn't inspect header files.
BRANCH=none
BUG=chromium:444723
TEST=Compiled Cosmos, Daisy, Blaze, Pit, Ryu, Storm and Pinky.
Change-Id: Id5739b144f6a5cfd40958ea68510dcf0b89fbfa9
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: f02cae8b04f2042530bafc91346d11bb666aa42d
Original-Change-Id: Ia91c2c19d8444e853a2fc12590a52c2b6447a1b9
Original-Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/254863
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/9835
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/arch/arm64')
| -rw-r--r-- | src/arch/arm64/include/arch/io.h | 4 | ||||
| -rw-r--r-- | src/arch/arm64/include/armv8/arch/arch_io.h | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/arch/arm64/include/arch/io.h b/src/arch/arm64/include/arch/io.h index cd75fb8920..9ec13dcf8b 100644 --- a/src/arch/arm64/include/arch/io.h +++ b/src/arch/arm64/include/arch/io.h @@ -32,9 +32,9 @@ * re-factor all code to specify the data length intended. */ #define readb(a) read8(a) -#define writeb(v,a) write8(v,a) +#define writeb(v,a) write8(a,v) #define readl(a) read32(a) -#define writel(v,a) write32(v,a) +#define writel(v,a) write32(a,v) /* * Clear and set bits in one shot. These macros can be used to clear and diff --git a/src/arch/arm64/include/armv8/arch/arch_io.h b/src/arch/arm64/include/armv8/arch/arch_io.h index 7d97c31dff..96a15d72a2 100644 --- a/src/arch/arm64/include/armv8/arch/arch_io.h +++ b/src/arch/arm64/include/armv8/arch/arch_io.h @@ -45,21 +45,21 @@ static inline uint32_t read32(const void *addr) return *(volatile uint32_t *)addr; } -static inline void write8(uint8_t val, void *addr) +static inline void write8(void *addr, uint8_t val) { dmb(); *(volatile uint8_t *)addr = val; dmb(); } -static inline void write16(uint16_t val, void *addr) +static inline void write16(void *addr, uint16_t val) { dmb(); *(volatile uint16_t *)addr = val; dmb(); } -static inline void write32(uint32_t val, void *addr) +static inline void write32(void *addr, uint32_t val) { dmb(); *(volatile uint32_t *)addr = val; |