diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-12-19 16:19:44 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-01-18 18:02:27 +0000 |
| commit | 66c6413c69abb7335efc4ea07f4c811c042704b6 (patch) | |
| tree | 06d58b85da4c779cca7b78e33a069ea03a4e69e4 /src/acpi/chromeos-gnvs.c | |
| parent | c4a6628a6fe4f5400b7abe1478d0b0b21cb8200f (diff) | |
ACPI: Refactor ChromeOS specific ACPI GNVS
The layout of GNVS has expectation for a fixed size
array for chromeos_acpi_t. This allows us to reduce
the exposure of <chromeos/gnvs.h>.
If chromeos_acpi_t was the last entry in struct global_nvs
padding at the end is also removed.
If device_nvs_t exists, place a properly sized reserve for
chromeos_acpi_t in the middle.
Allocation from cbmem is adjusted such that it matches exactly
the OperationRegion size defined inside the ASL.
Change-Id: If234075e11335ce958ce136dd3fe162f7e5afdf7
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48788
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/acpi/chromeos-gnvs.c')
| -rw-r--r-- | src/acpi/chromeos-gnvs.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/src/acpi/chromeos-gnvs.c b/src/acpi/chromeos-gnvs.c index 81c652ad3f..060d56d44b 100644 --- a/src/acpi/chromeos-gnvs.c +++ b/src/acpi/chromeos-gnvs.c @@ -5,11 +5,9 @@ #include <smbios.h> #include <vendorcode/google/chromeos/gnvs.h> -void gnvs_assign_chromeos(void) +void gnvs_assign_chromeos(void *gnvs_section) { - chromeos_acpi_t *gnvs_chromeos = gnvs_chromeos_ptr(acpi_get_gnvs()); - if (!gnvs_chromeos) - return; + chromeos_acpi_t *gnvs_chromeos = gnvs_section; chromeos_init_chromeos_acpi(gnvs_chromeos); @@ -22,7 +20,7 @@ void gnvs_assign_chromeos(void) void gnvs_set_ecfw_rw(void) { - chromeos_acpi_t *gnvs_chromeos = gnvs_chromeos_ptr(acpi_get_gnvs()); + chromeos_acpi_t *gnvs_chromeos = chromeos_get_chromeos_acpi(); if (!gnvs_chromeos) return; @@ -31,7 +29,7 @@ void gnvs_set_ecfw_rw(void) void smbios_type0_bios_version(uintptr_t address) { - chromeos_acpi_t *gnvs_chromeos = gnvs_chromeos_ptr(acpi_get_gnvs()); + chromeos_acpi_t *gnvs_chromeos = chromeos_get_chromeos_acpi(); if (!gnvs_chromeos) return; |