diff options
author | Dinesh Gehlot <digehlot@google.com> | 2023-05-08 05:15:53 +0000 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2023-05-11 16:50:35 +0000 |
commit | 8c53e6a053ac82a54c681b40fdd075aab3414e19 (patch) | |
tree | d0932bee9244d170b81273d7712e486ab5fecf06 /payloads/libpayload/libc/time.c | |
parent | f3027b809c1cab1a336df57f44e640ef2f632a1c (diff) |
soc/intel/cmn/blk.cse: Fix check condition in store_cse_rw_fw_version()
The return value of cse_get_bp_info() is an enum integer, where zero
means success and non-zero means failure. The function
store_cse_rw_fw_version() calls the function cse_get_bp_info() and
validates the return value as a boolean causing prematurely returns of
the parent API even if cse_get_bp_info() is successful.
This patch corrects this logical error by returning only if
cse_get_bp_info() fails.
TEST=Build and boot google/nivviks and verify that the ISH version info
command is only being sent during cold boot.
Signed-off-by: Dinesh Gehlot <digehlot@google.com>
Change-Id: Ice278e5ac69ff2f2c9f1936b76d71ae9deb6f855
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74998
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Diffstat (limited to 'payloads/libpayload/libc/time.c')
0 files changed, 0 insertions, 0 deletions