summaryrefslogtreecommitdiff
path: root/payloads/libpayload/libc/args.c
diff options
context:
space:
mode:
authorYouness Alaoui <youness.alaoui@puri.sm>2017-05-24 17:47:27 -0400
committerMartin Roth <martinroth@google.com>2017-06-09 17:01:27 +0200
commit2f48b7b1e9e3d0a631c7d8951c1a5b5dc748df09 (patch)
tree59694295c61211c41318a31a39582de0e681b6ab /payloads/libpayload/libc/args.c
parentb191c9f0ab5e9c4fb3f355a0cc2674e7861b0a68 (diff)
pciexp_device: Remove useless write on a read-only register
The Role-Based Error Reporting is not a configurable field, it's a read only field in the Device Capability register. This code was old and comes from commit f6eb88ad but evidently is not useful in any way. The PCIe Specification [1] states that it's read-only and must always be set to 1. I have also done tests on purism/librem13 hardware, trying to change that value, without any success. [1]: PCI Express Base Specification Revision 3.0 Page 612 Change-Id: I729617a5c6f4f52dfc4c422df78379b309066399 Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm> Reviewed-on: https://review.coreboot.org/19901 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'payloads/libpayload/libc/args.c')
0 files changed, 0 insertions, 0 deletions