summaryrefslogtreecommitdiff
path: root/payloads/libpayload/include/cbfs_ram.h
diff options
context:
space:
mode:
authorYidi Lin <yidilin@chromium.org>2022-08-05 15:40:48 +0800
committerMartin Roth <martin.roth@amd.corp-partner.google.com>2022-08-12 17:14:54 +0000
commit8610dd5022e0310ff36ed7132c574f65c001b1aa (patch)
treefa349e008c074563f29011e00f439e88066838c3 /payloads/libpayload/include/cbfs_ram.h
parenta4795c01ed161cb0d288272a6eaa363d26aef63d (diff)
libpayload: usbmsc: Prevent usbdisk_remove() from being called twice
When removing SD card from USB card reader, the USB MSC stack does not detach the device immediately. Instead, the USB MSC stack calls usbdisk_remove() and calls usb_msc_destroy() after several pollings. It results in usbdisk_remove() being called twice. Since the usbmsc_inst_t instance is freed after first usbdisk_remove() call, the second call invokes an invalid usbmsc_inst_t instance and causes exception in CPU. This patch prevents usbdisk_remove() from being called twice by setting usbdisk_created to zero. BUG=b:239492347 TEST=insert an empty SD card into the USB card reader then remove the SD card. AP firmware does not crash. Change-Id: I0675e9fde3e770d63dd0047928356a204245ef18 Signed-off-by: Yidi Lin <yidilin@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66449 Reviewed-by: Yu-Ping Wu <yupingso@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'payloads/libpayload/include/cbfs_ram.h')
0 files changed, 0 insertions, 0 deletions