diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2018-08-20 13:03:45 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-09-12 14:15:48 +0000 |
| commit | 9fc7b8e973fca05381be66e7053ffa301c9dbe33 (patch) | |
| tree | cc31fca29d6e6afede855ca249e3de3a69da8dce /payloads/libpayload/arch/x86/apic.c | |
| parent | 370c116ca5fa9e9d04ed61f445debde882b6a1cb (diff) | |
libpayload/x86/delay: Make arch_ndelay call apic_delay if delay is long
This reduces power consumption on grunt by over 3W when sitting at the
depthcharge recovery screen.
BUG=b:109749762
TEST=Booted grunt in the recovery screen and made sure it continued to
work.
Change-Id: Id079c099ee4cf6a07724241af4400063f4551668
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://review.coreboot.org/28245
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-by: Julius Werner <jwerner@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'payloads/libpayload/arch/x86/apic.c')
| -rw-r--r-- | payloads/libpayload/arch/x86/apic.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/payloads/libpayload/arch/x86/apic.c b/payloads/libpayload/arch/x86/apic.c index 079f456eec..99eff27aad 100644 --- a/payloads/libpayload/arch/x86/apic.c +++ b/payloads/libpayload/arch/x86/apic.c @@ -210,6 +210,8 @@ static void apic_init_timer(void) /* Set APIC init counter to MAX and count for 1 ms */ apic_write32(APIC_TIMER_INIT_COUNT, UINT32_MAX); + /* This is safe because apic_initialized() returns false so + * arch_ndelay() falls back to a busy loop. */ mdelay(1); ticks_per_ms = |