diff options
author | Matt DeVillier <matt.devillier@gmail.com> | 2024-11-01 09:56:36 -0500 |
---|---|---|
committer | Matt DeVillier <matt.devillier@gmail.com> | 2024-11-04 19:54:52 +0000 |
commit | c7bca700c8dbbdfaf47a27f287bbbab30a72313a (patch) | |
tree | f1ff25c87ce47ee5b81564684b5575c859cf388c /payloads/libpayload/arch/arm/selfboot.c | |
parent | 4953648253598ff5ebeeaf38fa4f3a23fd8b0e97 (diff) |
mb/google/fizz: Fix USB port defintions
commit 6c83a71b0a80 ("skl mainboards/dt: Move usb{2,3}_ports settings
into XHCI device scope") not only moved the USB port definitions under
the XHCI device reference, but also combined multiple register
definitions. In doing so, it broke the inheritance from the baseboard,
since the variant overridetree registers now replaced the entire
usb2_ports/usb3_ports structs, rather than replacing individual array
elements therein. This resulted in any USB ports inherited from the
baseboard and not overridden by the variant being non-functional as they
were not included in the resulting combined devicetree.
To fix this, return to overriding individual array elements in the
usb2/3_ports structs.
TEST=build/boot google/fizz/var/karma. Verify all USB ports present and
functional. Verify mainboard/static.c in built shows all ports.
Change-Id: I0e80bf4949a857c21d44537eb720a7a8a7db2f80
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84955
Reviewed-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'payloads/libpayload/arch/arm/selfboot.c')
0 files changed, 0 insertions, 0 deletions