diff options
author | Simon Glass <sjg@chromium.org> | 2020-06-29 16:18:37 -0600 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2020-07-01 04:52:47 +0000 |
commit | 8bfa51e4c485ec85c872254a4cf724a40554370f (patch) | |
tree | 80dfb8b558d680ef1b5558d40683a75f2ce92813 /configs | |
parent | 84b9653b38fd4653cd094105150d1e11b3f3ecdb (diff) |
acpi: Avoid freeing a device twice
The current implementation of acpi_dp_write() frees the node after it
has written it.
If the structure contains a ACPI_DP_TYPE_CHILD then a recursive call to
acpi_dp_write() frees the child and then frees it again when returning
from the call. This results in a double free.
Split the implementation into two steps, one that ones and one that
frees. This is easier to understand and fixes the bug.
Note: This likely has no effect in coreboot since it doesn't seem to
have a proper free() implementation. But it might gain one one day.
BUG=none
Signed-off-by: Simon Glass <sjg@chromium.org>
Change-Id: Ife3917af10bc35a3c3eee38d8292f927ef15409d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42892
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'configs')
0 files changed, 0 insertions, 0 deletions