diff options
| author | Elyes HAOUAS <ehaouas@noos.fr> | 2021-12-08 13:19:41 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2022-01-28 16:34:23 +0000 |
| commit | 28fa297901ffd158631cfc9f562f38119eff628e (patch) | |
| tree | 4081b995b0f1f02b6d826111129558ff75d37a44 /Makefile.inc | |
| parent | 5e84a42055cd741d38923dc152745a759ee4587f (diff) | |
IASL: Ignore IASL's "Missing dependency" warning
IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects:
1) If _PRS is present, must have _CRS and _SRS
2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS)
3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS)
4) If _SRS is present, probably should have a _DIS (Remark only)
IASL will issue a warning for each missing dependency.
Ignore this warnings for existing ASL code and issue a message when the build is complete.
Change-Id: I28b437194f08232727623009372327fec15215dd
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59880
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'Makefile.inc')
| -rw-r--r-- | Makefile.inc | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/Makefile.inc b/Makefile.inc index beb7f0e531..f58418951b 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -263,9 +263,26 @@ EMPTY_RESOURCE_TEMPLATE_WARNING = 3150 # Redundant offset remarks are not useful in any way and are masking useful # ones that might indicate an issue so it is better to hide them. REDUNDANT_OFFSET_REMARK = 2158 +# IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: +# 1) If _PRS is present, must have _CRS and _SRS +# 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) +# 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) +# 4) If _SRS is present, probably should have a _DIS (Remark only) +# A warning will be issued for each of these cases. +# For existing ASL code, ignore this warnings +IASL_MISSING_DEPENDENCY = 3141 IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) $(REDUNDANT_OFFSET_REMARK) +ifeq ($(CONFIG_IGNORE_IASL_MISSING_DEPENDENCY),y) + IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) +build_complete:: + printf "*** WARNING: The ASL code for this platform is incomplete. Please fix it. ***\n" + printf "*** If _PRS is present, must have _CRS and _SRS ***\n" + printf "*** If _SRS is present, must have _PRS, _CRS, and _SRS ***\n" + printf "*** If _DIS is present, must have _SRS, _PRS, _CRS, and _SRS ***\n" +endif + IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST)) define asl_template |