summaryrefslogtreecommitdiff
path: root/Documentation/northbridge
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2020-05-26 19:03:31 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-05-28 09:46:17 +0000
commit5f17458cfbe90171bf6d20d9c36470ebbfb3842f (patch)
treeb711f3d50410500df9be7141529dd43b6140652d /Documentation/northbridge
parent4cabf789fd7615318cd0552e490c252ba0f142a6 (diff)
drivers/vpd: Fix VPD speed regressions on non-x86 devices
CB:34634 expanded the VPD code to also be usable from romstage, shuffling a few things around and adding some extra infrastructure in the process. Unfortunately, the changes seem to have only been written with x86 devices in mind and make coreboot always load the whole VPD FMAP section (not just the used part) on devices where rdev_mmap() is not a no-op. This patch rewrites the VPD code to be based on region_device structures that only represent the VPD area actually used (rather than the whole FMAP section), and that only get mapped when accessed. (It would be even better to pull this concept into the VPD decoder itself, but since that is taken from third-party code and accesses in early stages aren't very common, let's not go there for now.) It also moves the copying into CBMEM to romstage so that late romstage accesses can already benefit from it, and makes early decoding available in all stages because at this point, why not. Also fix a long-standing bug where the 'consumed' counter was not reset between vpd_decode_string() calls to the RO and the RW VPD. Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I55a103180b290c1563e35a25496188b6a82e49ff Reviewed-on: https://review.coreboot.org/c/coreboot/+/41757 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Diffstat (limited to 'Documentation/northbridge')
0 files changed, 0 insertions, 0 deletions