summaryrefslogtreecommitdiff
path: root/Documentation/mainboard/facebook/fbg1701.md
diff options
context:
space:
mode:
authorMaximilian Brune <maximilian.brune@9elements.com>2024-07-23 11:44:39 +0200
committerFelix Held <felix-coreboot@felixheld.de>2024-08-19 14:10:21 +0000
commit2355aa7d3ba490512483925b6362ec45064a8c0f (patch)
treed55d238cf82661f3c1920e5ba5275568ccedcbf9 /Documentation/mainboard/facebook/fbg1701.md
parent5d661b81ae2d3e0e85db73dd7e5d3a68f89ed553 (diff)
util/cbfstool/cbfs-payload-linux: Do not compress bzImage
Compressing the already compressed bzImage does not yield any fruit. If you are lucky it actually makes the image a little bit smaller. If you are unlucky the image actually gets bigger and since the compressing function is not checked for any errors, coreboot just builds successfully even though the payload is broken through compression. Before this patch you could possibly get this error during compilation: ``` E: LZMA: LzmaEnc_Encode failed 9. ``` and your linux payload would end up something like this in CBFS: ``` FMAP REGION: COREBOOT Name Offset Type Size Comp .... fallback/payload 0x1c9c0 simple elf 511 none .... ``` That doesn't stop coreboot from finishing the build though, since we currently don't check for errors from the compression. That is an issue for another patch though. Tested: Build and run QEMU-Q35 with Linux bzImage as payload. Change-Id: I022982667515ce721d98af534414d9e336b5f35a Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83615 Reviewed-by: coreboot org <coreboot.org@gmail.com> Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'Documentation/mainboard/facebook/fbg1701.md')
0 files changed, 0 insertions, 0 deletions