summaryrefslogtreecommitdiff
path: root/Documentation/lib
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-08-11 22:54:06 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-08-13 16:45:25 +0000
commit414d7e4642991696dc81fbcb7ac68fe75fa4bc12 (patch)
treedb37523055a7999ac18f49c21da570b046d786f1 /Documentation/lib
parent8aad2cafedea5de0211bd4b44dcfe78bd7eedc4b (diff)
drivers/intel/fsp2_0: don't select FSP_USES_CB_STACK on FSP 2.0 platform
soc/amd/picasso selected FSP_USES_CB_STACK even though it is FSP 2.0 based, so it doesn't reuse coreboot's stack, but sets up its own stack. In contrast to all other FSP 2.0 based platforms, this stack isn't in the CAR region, since AMD Picasso doesn't support CAR and the DRAM is already available when the x86 cores are released from reset. Selecting FSP_USES_CB_STACK ended up doing the right thing, but is semantically wrong. Instead of wrongly selecting FSP_USES_CB_STACK in soc/amd/picasso we take the corresponding code path if ENV_CACHE_AS_RAM is false which is only the case for non-CAR platforms. BUG=b:155501050 TEST=Timeless build results in an identical binary for amd/mandolin, asrock/h110m-dvs and intel/coffeelake_rvp11 which cover all 3 cases here. Change-Id: Icd0ff8e17a535e2c247793b64f4b0565887183d8 Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44406 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'Documentation/lib')
0 files changed, 0 insertions, 0 deletions