diff options
| author | Martin Roth <gaumless@gmail.com> | 2024-03-11 10:09:57 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2024-03-13 13:58:36 +0000 |
| commit | 30bd24fd267af34b9e12408cd6a2cda27c893ebd (patch) | |
| tree | 9040e5298eff34a9d97a7639d135675885961d88 /Documentation/contributing | |
| parent | 7f922104854eb8c5df97ad35adc17d1681afdc0c (diff) | |
Docs: Update gerrit guidelines for -1 reviews
The -1 review authority has been moved from all registered users to
users in the "reviewers" category. The reviewers group is for people
who have submitted patches to coreboot.
This change is taking the project back to how it was before 2016, and
is not due to any issues that we're seeing. The reason it was initially
changed was that in 2016, before we required all comments to be resolved
so the patch could be merged, it was easy to overlook comments that
should have been addressed. Now that the process has changed, the -1
right is no longer needed for all users simply to bring attention to
the comment.
The feeling in the leadership meeting was that since it's relatively
easy to get to reviewer status, this should not be an undue burden on
anyone.
Change-Id: I0b7f3dcc80b9122b0f923e6703da73391654d26c
Signed-off-by: Martin Roth <gaumless@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81177
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nicholas Chin <nic.c3.14@gmail.com>
Diffstat (limited to 'Documentation/contributing')
| -rw-r--r-- | Documentation/contributing/gerrit_guidelines.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Documentation/contributing/gerrit_guidelines.md b/Documentation/contributing/gerrit_guidelines.md index 235277bb12..ce6fa6fbf1 100644 --- a/Documentation/contributing/gerrit_guidelines.md +++ b/Documentation/contributing/gerrit_guidelines.md @@ -395,8 +395,8 @@ Gerrit user roles There are a few relevant roles a user can have on Gerrit: - The anonymous user can check out source code. -- A registered user can also comment and give "+1" and "-1" code reviews. -- A reviewer can also give "+2" code reviews. +- A registered user can also comment and give "+1" code reviews. +- A reviewer can give "-1" and "+2" code reviews. - A core developer can also give "-2" (that is, blocking) code reviews and submit changes. |