summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2022-11-13 12:18:05 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-11-17 13:18:59 +0000
commitfda7d07b7bdb044b127ae0199af3e4c5c9401ad1 (patch)
tree4674cc3373d408935841eabd47e49feaca9b3f36
parent2e9849aa02f820a0ba93aafaa77404f6b19849df (diff)
mb/starlabs/starbook/kbl: Drop redundant option code
Commit 9bbc039c457774dbeb44ea37ecc6507144d49b61 ("soc/intel/skylake: Hook up FSP hyper-threading setting to option API") already hooks up the `hyper_threading` CMOS option in SoC code, so there's no need to do it from mainboard code. Change-Id: I602452266a8465cced12454f800ea023f382ba6f Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69522 Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Sean Rhodes <sean@starlabs.systems> Reviewed-by: Felix Singer <felixsinger@posteo.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/starlabs/starbook/variants/kbl/romstage.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c
index 098f753f1d..72fe9ede58 100644
--- a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c
+++ b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c
@@ -19,8 +19,4 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
mem_cfg->MemorySpdPtr00 = spd_cbfs_map(6);
mem_cfg->MemorySpdPtr10 = mem_cfg->MemorySpdPtr00;
mem_cfg->MemorySpdDataLen = CONFIG_DIMM_SPD_SIZE;
-
- const uint8_t ht = get_uint_option("hyper_threading",
- mupd->FspmConfig.HyperThreading);
- mupd->FspmConfig.HyperThreading = ht;
}