summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2022-12-19 15:16:32 -0600
committerMartin L Roth <gaumless@gmail.com>2022-12-22 20:44:18 +0000
commitf75172fdcc723cf9b22589979bb47398b1c47ab2 (patch)
treea3036d36fabbd5a4eed237a465ac088c9c88009a
parent27937169104c1b2f6ec3132e0511719abe9477de (diff)
mb/google/poppy: update ACPI HID/CID for Synaptics touchpad
The currently assigned ACPI HID 'PNP0C50' is not a valid per Windows WHQL validation tests. To ensure compatibility with both Windows and Linux, set the HID to 'SYNA0000' and CID to 'ACPI0C50' as previously done for other boards (eg, google/lulu). TEST=boot Linux 5.1x, Windows 10 on nami, verify all touchpad functions work correctly. Change-Id: I0611da8bbea41565e603a1a1b7cc20226ba21c62 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/71075 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/mainboard/google/poppy/variants/nami/devicetree.cb3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 8583518e5f..12ac72169a 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -347,7 +347,8 @@ chip soc/intel/skylake
device i2c 15 on end
end
chip drivers/i2c/hid
- register "generic.hid" = ""PNP0C50""
+ register "generic.hid" = ""SYNA0000""
+ register "generic.cid" = ""ACPI0C50""
register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E3_IRQ)"
register "generic.wake" = "GPE0_DW2_16"