diff options
| author | Felix Singer <felixsinger@posteo.net> | 2022-12-16 04:07:23 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-12-19 16:13:50 +0000 |
| commit | f3649f03f3fd0f5ff8b6e08a3a2e313ed670d3fa (patch) | |
| tree | 9736200e367d5c4bbe48346e05aedec46ea782f9 | |
| parent | 848c37da42572df8930bb9651c70a2fab91ba131 (diff) | |
tree: Replace XOr(a,b,c) with ASL 2.0 syntax
Replace `XOr (a, b, c)` with `c = a ^ b`, respectively `c ^= b` where
possible.
Change-Id: Ic5f67684bbd4ea115c4dae8a4417d88bea0d6b77
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70843
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
| -rw-r--r-- | src/ec/quanta/it8518/acpi/battery.asl | 4 | ||||
| -rw-r--r-- | src/ec/smsc/mec1308/acpi/battery.asl | 4 | ||||
| -rw-r--r-- | src/mainboard/google/parrot/acpi/mainboard.asl | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 7a3f77467a..e63cefb7c5 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -106,7 +106,7 @@ Device (BATX) // ACPI spec : 0 - mWh : 1 - mAh // Local7 = SBCM - XOr (Local7, One, PBIF[0]) + PBIF[0] = Local7 ^ One // // Information ID 0 - @@ -282,7 +282,7 @@ Device (BATX) } } - XOr (DerefOf (PBIF[0]), One, Local6) + Local6 = DerefOf (PBIF[0]) ^ One If (Local6) { diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index 7669513a68..257897fb48 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -134,7 +134,7 @@ Device (BAT0) Local1 = SWAB (BTPR) If (Local1 != 0xFFFFFFFF && Local1 >= 0x8000) { - Xor (Local1, 0xFFFF, Local1) + Local1 ^= 0xFFFF Local1++ } PBST[1] = Local1 @@ -144,7 +144,7 @@ Device (BAT0) // Local1 = SWAB (BTRA) If (Local1 != 0xFFFFFFFF && Local1 >= 0x8000) { - Xor (Local1, 0xFFFF, Local1) + Local1 ^= 0xFFFF Local1++ } diff --git a/src/mainboard/google/parrot/acpi/mainboard.asl b/src/mainboard/google/parrot/acpi/mainboard.asl index 6d5e9070fe..7fc07fa6f1 100644 --- a/src/mainboard/google/parrot/acpi/mainboard.asl +++ b/src/mainboard/google/parrot/acpi/mainboard.asl @@ -11,7 +11,7 @@ Scope (\_GPE) { * changes again. GIV1 is the interrupt level control * register for GPIO bits 15:8 */ - Xor(GIV1, 0x80, GIV1) + GIV1 ^= 0x80 Notify(\_SB.LID0,0x80) } } |