diff options
| author | Julius Werner <jwerner@chromium.org> | 2019-04-09 15:57:07 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-04-11 11:21:55 +0000 |
| commit | f0286047189cd1a116486ec57284cbdfeafe7a3a (patch) | |
| tree | 80ffbf50bf2dc001b2b1637ede38dec83b9a3523 | |
| parent | 5de93e9011c66d91adc1bd176a7cdcd2ab32a47c (diff) | |
kconfig_lint: Make uses of CONFIG() on an unknown option an error
This check had very few false positives which were all easily resolved,
and it's unlikely that further false positives will become problematic
in the future. On the other hand, it does detect a very severe bug (when
you think you're using a Kconfig but you aren't due to a typo), so since
warnings are currently not very visible, let's turn this into an error
because the pros clearly outweigh the cons for that.
Change-Id: I897b5e13d3242fb77b69f0bd3585baa7476aa726
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32257
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rwxr-xr-x | util/lint/kconfig_lint | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 4d0a755efb..502a61878b 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -47,7 +47,7 @@ my $warnings_found = 0; my $exclude_dirs_and_files = '^build/\|^coreboot-builds/\|^configs/\|^util/\|^\.git/\|^payloads\|^Documentation\|^3rdparty' . '\|' . # directories to exclude when searching for used symbols - '\.config\|\.txt$\|\.tex$\|\.tags'; #files to exclude when looking for symbols + '\.config\|\.txt$\|\.tex$\|\.tags\|/kconfig.h'; #files to exclude when looking for symbols my $payload_files_to_check='payloads/Makefile.inc payloads/external/Makefile.inc'; my $config_file = ""; # name of config file to load symbol values from. my @wholeconfig; # document the entire kconfig structure @@ -314,7 +314,7 @@ sub check_is_enabled { } } else { - show_warning("CONFIG() used on unknown value ($symbol) at $file:$lineno."); + show_error("CONFIG() used on unknown value ($symbol) at $file:$lineno."); } } } elsif ( $line =~ /^([^:]+):(\d+):(.+IS_ENABLED.*)/ ) { |