diff options
| author | Elyes Haouas <ehaouas@noos.fr> | 2023-09-06 19:50:28 +0200 |
|---|---|---|
| committer | Elyes Haouas <ehaouas@noos.fr> | 2023-09-07 17:35:19 +0000 |
| commit | db3e16e73cb8c11c2422274729f418239f2a4a02 (patch) | |
| tree | 07784385acd6b996520f877539389f2bf3805111 | |
| parent | 19b4e6487fb31657bb2d39a03afc14dfa9bd7cc1 (diff) | |
security/intel: Remove unnecessary blank line after '{'
Change-Id: I0d2a9c30d332b16efd548433a54f974067bd281e
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77705
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
| -rw-r--r-- | src/security/intel/stm/SmmStm.c | 3 | ||||
| -rw-r--r-- | src/security/intel/stm/StmPlatformResource.c | 2 | ||||
| -rw-r--r-- | src/security/intel/stm/StmPlatformSmm.c | 1 | ||||
| -rw-r--r-- | src/security/intel/txt/romstage.c | 2 |
4 files changed, 0 insertions, 8 deletions
diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index a062bda25b..3371f02efe 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -38,7 +38,6 @@ #define STM_SM_MONITOR_STATE_ENABLED 1 typedef struct { - uint64_t vmcs_revision_id : 31; uint64_t always_zero : 1; uint64_t vmcs_size : 13; @@ -482,7 +481,6 @@ int add_pi_resource(STM_RSC *resource_list, uint32_t num_entries) return -1; // INVALID_PARAMETER; if (!m_stm_resources_ptr) { - // Copy EndResource for initialization m_stm_resources_ptr = stm_resource_heap; m_stm_resource_total_size = CONFIG_BIOS_RESOURCE_LIST_SIZE; @@ -648,7 +646,6 @@ bool stm_check_stm_image(void *stm_image, uint32_t stm_imagesize) if (stm_header->hw_stm_hdr.cr3_offset >= stm_header->sw_stm_hdr.static_image_size) { - // We will create page table, just in case that SINIT does not // create it. if (min_mseg_size < stm_header->hw_stm_hdr.cr3_offset diff --git a/src/security/intel/stm/StmPlatformResource.c b/src/security/intel/stm/StmPlatformResource.c index ad7cf1dd7f..62559873c3 100644 --- a/src/security/intel/stm/StmPlatformResource.c +++ b/src/security/intel/stm/StmPlatformResource.c @@ -152,7 +152,6 @@ static void add_msr_resources(void) uint32_t Index; for (Index = 0; Index < ARRAY_SIZE(msr_table); Index++) { - rsc_msr_tpl.msr_index = (uint32_t)msr_table[Index].msr_index; rsc_msr_tpl.read_mask = (uint64_t)msr_table[Index].read_mask; rsc_msr_tpl.write_mask = (uint64_t)msr_table[Index].write_mask; @@ -172,7 +171,6 @@ extern uint8_t *m_stm_resources_ptr; void add_resources_cmd(void) { - m_stm_resources_ptr = NULL; add_simple_resources(); diff --git a/src/security/intel/stm/StmPlatformSmm.c b/src/security/intel/stm/StmPlatformSmm.c index e5b3cf1d74..69df5cd6b1 100644 --- a/src/security/intel/stm/StmPlatformSmm.c +++ b/src/security/intel/stm/StmPlatformSmm.c @@ -162,7 +162,6 @@ void stm_setup(uintptr_t mseg, int cpu, uintptr_t smbase, stm_resource_heap = (uint8_t *)addr_calc; if (cpu == 0) { - // need to create the BIOS resource list once printk(BIOS_DEBUG, "STM: stm_resource_heap located at %p\n", stm_resource_heap); diff --git a/src/security/intel/txt/romstage.c b/src/security/intel/txt/romstage.c index fa0ba3c7ff..aa7cc2c0a3 100644 --- a/src/security/intel/txt/romstage.c +++ b/src/security/intel/txt/romstage.c @@ -69,13 +69,11 @@ void intel_txt_romstage_init(void) const bool is_wake_error = !!(txt_ests & TXT_ESTS_WAKE_ERROR_STS); if (CONFIG(INTEL_TXT_LOGGING)) { - printk(BIOS_INFO, "TEE-TXT: TPM established: %s\n", establishment ? "true" : "false"); } if (establishment && is_wake_error) { - printk(BIOS_ERR, "TEE-TXT: Secrets remain in memory. SCLEAN is required.\n"); if (txt_ests & TXT_ESTS_TXT_RESET_STS) { |