diff options
| author | Felix Held <felix.held@amd.corp-partner.google.com> | 2021-08-28 00:01:45 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-08-30 13:44:36 +0000 |
| commit | db3337d9297d1f1d7759ffaa846115f946701906 (patch) | |
| tree | aaac50752af08f60c75848d33e974f32f04d4009 | |
| parent | 73ed5991bc42caf306fd6f2b13696853b7069e02 (diff) | |
soc/amd/common/fsp/Makefile: drop strip_quotes call in FSP-M size check
No need to strip the quotes of the FSP-M file path in the size check and
it's always a good idea to not remove the quotes around file paths that
will get passed as parameters to shell programs so that spaces in the
path can't cause malfunction.
TEST=All cases still behave as expected for Mandolin.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Nico Huber <nico.h@gmx.de>
Change-Id: Ieeea84b5861f9d15b2472208432169dc8e3f0049
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57218
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
| -rw-r--r-- | src/soc/amd/common/fsp/Makefile.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/common/fsp/Makefile.inc b/src/soc/amd/common/fsp/Makefile.inc index ee5e1ac19a..eac9e0636d 100644 --- a/src/soc/amd/common/fsp/Makefile.inc +++ b/src/soc/amd/common/fsp/Makefile.inc @@ -11,7 +11,7 @@ ifeq ($(CONFIG_FSP_M_FILE),) $(info There's no FSP-M binary file specified. The resulting image won't boot successfully.) else ifeq ($(call int-gt,\ - $(call file-size,$(call strip_quotes,$(CONFIG_FSP_M_FILE)))\ + $(call file-size,$(CONFIG_FSP_M_FILE))\ $(shell printf "%d" $(CONFIG_FSP_M_SIZE))),\ 1) $(error FSP-M binary larger than FSP_M_FILE.) |