diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2022-11-13 12:52:15 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-11-15 13:14:17 +0000 |
| commit | d704c76b9f36a4fbe26898bfe257cef02a1d5421 (patch) | |
| tree | 5417e4a00654d098cf1eeff6d3911893e256c140 | |
| parent | 9a1da4bd0769f110c1c1ddeeba28dc167ebc66c8 (diff) | |
mb/clevo/cml-u: Fix CMOS options
The `hyper_threading` CMOS option was hooked up to the wrong enumeration
and lacked a default value in `cmos.default`. Thus, use the correct enum
for the `hyper_threading` option, remove the now-unused "backwards" enum
and provide a default value in `cmos.default`.
Change-Id: I56b0320f9210cde8ff58db176d2b7d2207c98aa9
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69521
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/clevo/cml-u/cmos.default | 1 | ||||
| -rw-r--r-- | src/mainboard/clevo/cml-u/cmos.layout | 4 |
2 files changed, 2 insertions, 3 deletions
diff --git a/src/mainboard/clevo/cml-u/cmos.default b/src/mainboard/clevo/cml-u/cmos.default index a20f1b187a..098bfa6949 100644 --- a/src/mainboard/clevo/cml-u/cmos.default +++ b/src/mainboard/clevo/cml-u/cmos.default @@ -1,5 +1,6 @@ boot_option=Fallback debug_level=Debug +hyper_threading=Enable power_on_after_fail=Disable # EC options diff --git a/src/mainboard/clevo/cml-u/cmos.layout b/src/mainboard/clevo/cml-u/cmos.layout index 391deb16eb..8350704ff0 100644 --- a/src/mainboard/clevo/cml-u/cmos.layout +++ b/src/mainboard/clevo/cml-u/cmos.layout @@ -17,7 +17,7 @@ entries # ----------------------------------------------------------------- # coreboot config options: cpu -400 1 e 2 hyper_threading +400 1 e 1 hyper_threading # ----------------------------------------------------------------- # coreboot config options: southbridge @@ -52,8 +52,6 @@ enumerations #ID value text 1 0 Disable 1 1 Enable -2 0 Enable -2 1 Disable 4 0 Fallback 4 1 Normal 6 0 Emergency |