aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2024-05-24 17:59:23 +0200
committerFelix Held <felix-coreboot@felixheld.de>2024-05-27 12:40:14 +0000
commitca88b5f0aca3b1dce29baa1c57e02d3202dea29c (patch)
treec8e80ef66ebc6c7311d561136eee107ca735ea67
parent96a193afa67ecbce3d6c6d1228120717be19536a (diff)
acpi/acpi_apic: use generic MADT IRQ override function for SCI override
Call acpi_create_madt_irqoverride from acpi_create_madt_sci_override with the correct parameters instead or re-implementing the same functionality. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I7e6ee0eed837c2d46da62092b7cc5669dc177d8d Reviewed-on: https://review.coreboot.org/c/coreboot/+/82644 Reviewed-by: Eric Lai <ericllai@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
-rw-r--r--src/acpi/acpi_apic.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c
index ebff44f2bb..b47586dedc 100644
--- a/src/acpi/acpi_apic.c
+++ b/src/acpi/acpi_apic.c
@@ -130,14 +130,7 @@ static int acpi_create_madt_sci_override(acpi_madt_irqoverride_t *irqoverride)
if (!CONFIG(ACPI_HAVE_PCAT_8259))
irq = gsi;
- irqoverride->type = IRQ_SOURCE_OVERRIDE; /* Interrupt source override */
- irqoverride->length = sizeof(acpi_madt_irqoverride_t);
- irqoverride->bus = MP_BUS_ISA;
- irqoverride->source = irq;
- irqoverride->gsirq = gsi;
- irqoverride->flags = flags;
-
- return irqoverride->length;
+ return acpi_create_madt_irqoverride(irqoverride, MP_BUS_ISA, irq, gsi, flags);
}
static unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current)