diff options
| author | Yidi Lin <yidilin@chromium.org> | 2022-08-16 14:35:53 +0800 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-08-18 18:25:27 +0000 |
| commit | c1de4b456b9fe9a4b79112e103ce5ee41ba837f7 (patch) | |
| tree | 457148760d53e82386070c8b32110d6b1cc50c16 | |
| parent | d5568f46e810be89d2182710fbf9ce9e2976a33c (diff) | |
soc/mediatek/mt8186: spm: Remove redundant call
spm_set_power_control() is already called in spm_init(). It is not
necessary to call spm_set_power_control() again in the mtk_mcu reset
callback.
TEST=check SPM PC value (0x250) after SPM is loaded.
[INFO ] SPM: spm_init done in 54 msecs, spm pc = 0x250
Signed-off-by: Yidi Lin <yidilin@chromium.org>
Change-Id: I7ee517e1eb6485c52155a69d05781a61ddfe4cad
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66785
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/mediatek/mt8186/spm.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/soc/mediatek/mt8186/spm.c b/src/soc/mediatek/mt8186/spm.c index 30d56ff1a3..cc4164f47f 100644 --- a/src/soc/mediatek/mt8186/spm.c +++ b/src/soc/mediatek/mt8186/spm.c @@ -648,7 +648,6 @@ static void reset_spm(struct mtk_mcu *mcu) spm_reset_and_init_pcm(); spm_kick_im_to_fetch(pcm); spm_init_pcm_register(); - spm_set_power_control(&spm_init_ctrl); spm_set_wakeup_event(&spm_init_ctrl); spm_kick_pcm_to_run(&spm_init_ctrl); } |