diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2021-06-14 17:12:58 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-06-15 19:46:47 +0000 |
| commit | a5061f8f5772e59725c8e89e02b9dff10735e915 (patch) | |
| tree | 47596bde32b38c1eff00d8ed73f44b09ff53a1d6 | |
| parent | 47ad2ae3f984ffa6fb3803bdbea6bd7d96bad819 (diff) | |
tpm/tss: Remove local variable
Depending on how the "middle-end" (yes, the gcc developers are
serious about that) optimizer ends up mangling the code, there may
or may not be a complaint about x being used uninitialized when it's
clearly not used at all.
So instead, why keep x in the first place? memcpy(foo, NULL, 0) is
the same as memcpy(foo, some_uninitialized_variable, 0) in that it
does nothing.
Change-Id: Ib0a97c3e3fd1a2a6aff37da63376373c88ac595d
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55499
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/security/tpm/tss/tcg-1.2/tss.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/security/tpm/tss/tcg-1.2/tss.c b/src/security/tpm/tss/tcg-1.2/tss.c index 413b68193f..52bc2722b2 100644 --- a/src/security/tpm/tss/tcg-1.2/tss.c +++ b/src/security/tpm/tss/tcg-1.2/tss.c @@ -327,9 +327,8 @@ uint32_t tlcl_get_flags(uint8_t *disable, uint8_t *deactivated, uint32_t tlcl_set_global_lock(void) { - uint32_t x; VBDEBUG("TPM: Set global lock\n"); - return tlcl_write(TPM_NV_INDEX0, (uint8_t *) &x, 0); + return tlcl_write(TPM_NV_INDEX0, NULL, 0); } uint32_t tlcl_extend(int pcr_num, const uint8_t *in_digest, |