diff options
| author | Werner Zeh <werner.zeh@siemens.com> | 2021-10-07 07:15:38 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-10-13 13:57:05 +0000 |
| commit | a31d6cd5d02a21452d92859a682ebbc674080c49 (patch) | |
| tree | 603ffb5ea940a6f2eb2ac836a56280961aa855d2 | |
| parent | 302b1e508ca1eb3edb551511e24db70bb1624eb4 (diff) | |
drivers/pc80/tpm: Fix wrong debug message
There is the wrong register offset printed in the debug log when the
data register is written:
'lpc_tpm: Write reg 0x18 with 0xnn' should be
'lpc_tpm: Write reg 0x24 with 0xnn' for data FIFO access.
This can be confusing when searching for issues with the help of the
TPM debug messages since the code itself is correct. Fix this error.
Change-Id: Ic28ee5a07146e804574b887ea05c62e7e88e9078
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58155
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
| -rw-r--r-- | src/drivers/pc80/tpm/tis.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 526b574611..2b29acfaa9 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -172,7 +172,7 @@ static inline u8 tpm_read_data(int locality) static inline void tpm_write_data(u8 data, int locality) { - TPM_DEBUG_IO_WRITE(TIS_REG_STS, data); + TPM_DEBUG_IO_WRITE(TIS_REG_DATA_FIFO, data); write8(TIS_REG(locality, TIS_REG_DATA_FIFO), data); } |