diff options
| author | Martin Roth <martinroth@google.com> | 2018-01-22 21:41:58 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2018-01-24 23:01:35 +0000 |
| commit | a2fc1aee446f7cafa0e275c69fcb54adb5bf233d (patch) | |
| tree | e1ff758199165154ed52c19cf8c0b1b0440ecef0 | |
| parent | 9cf2f707ab4f4aff0812949222fc41a57ae00dd3 (diff) | |
payloads/nvramcui/payload.sh: Fix shellcheck warnings
In payloads/nvramcui/payload.sh line 5:
DIR=`dirname $0`
^-- SC2006: Use $(..) instead of deprecated `..`
^-- SC2086: Double quote to prevent globbing and word \
splitting.
In payloads/nvramcui/payload.sh line 6:
lpgcc -o $DIR/nvramcui.elf $DIR/nvramcui.c 2>&1 >/dev/null || exit 1
^-- SC2086: Double quote to prevent globbing and word \
splitting.
^-- SC2086: Double quote to prevent \
globbing and word splitting.
^-- SC2069: The order of \
of the 2>&1 and the \
redirect matters. The \
2>&1 has to be last.
Change-Id: Iceab2d0df49c642f54e6b911793aa1479f542644
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/23373
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rwxr-xr-x | payloads/nvramcui/payload.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/payloads/nvramcui/payload.sh b/payloads/nvramcui/payload.sh index 57ed38b3a6..3d171e6949 100755 --- a/payloads/nvramcui/payload.sh +++ b/payloads/nvramcui/payload.sh @@ -2,6 +2,6 @@ # # This is a trivial payload compile & find script for abuild # -DIR=`dirname $0` -lpgcc -o $DIR/nvramcui.elf $DIR/nvramcui.c 2>&1 >/dev/null || exit 1 +DIR=$(dirname "$0") +lpgcc -o "$DIR/nvramcui.elf" "$DIR/nvramcui.c" >/dev/null 2>&1 || exit 1 echo "$DIR/nvramcui.elf" |