summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2018-05-01 21:52:42 -0500
committerMartin Roth <martinroth@google.com>2018-05-03 01:32:16 +0000
commit9c05598f7a4553bb7b7da62f7e6e186f0713517e (patch)
tree24feb1b18bd7b3efe2849491dde7a8752e624b13
parent37dd7064e124edfd35070ec779eaca40b62a127f (diff)
ec/google/chromeec: Update Tablet event call
The tablet event handler method TPET is defined as an extern, then defined again in skylake, the only platform that supports it. In newer versions of IASL, this generates an error, as the method is defined in two places. Remove the extern and the CondRefOf check. That's not needed if we only set the EC_ENABLE_TABLET_EVENT define on platforms that have a TPET handler. Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/25983 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
-rw-r--r--src/ec/google/chromeec/acpi/ec.asl6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl
index 9ec5f7f3c5..ac4ceb16c5 100644
--- a/src/ec/google/chromeec/acpi/ec.asl
+++ b/src/ec/google/chromeec/acpi/ec.asl
@@ -24,7 +24,7 @@ External (\_TZ.THRT, MethodObj)
#ifdef DPTF_ENABLE_CHARGER
External (\_SB.DPTF.TCHG, DeviceObj)
#endif
-External (\_SB.DPTF.TPET, MethodObj)
+
Device (EC0)
{
@@ -373,9 +373,7 @@ Device (EC0)
Store ("EC: TABLET mode switch Event", Debug)
Notify (CREC, 0x2)
#ifdef EC_ENABLE_TABLET_EVENT
- If (CondRefOf (\_SB.DPTF.TPET)) {
- \_SB.DPTF.TPET()
- }
+ \_SB.DPTF.TPET()
#endif
#ifdef EC_ENABLE_TBMC_DEVICE
Notify (TBMC, 0x80)