diff options
| author | Paul Menzel <pmenzel@molgen.mpg.de> | 2017-03-17 12:15:14 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-03-21 18:20:31 +0100 |
| commit | 98adaf5989845f7859054f5cee2cf1f4e0392640 (patch) | |
| tree | 42a80f523860f443c669d3064ac36814cb1810d8 | |
| parent | 237ca0d20c932d2e7334a158e4418a69965b845b (diff) | |
mainboards: Don’t select `CONSOLE_POST`
Currently, it’s impossible for the user to select `NO_POST`, for boards
selecting `CONSOLE_POST` in their config.
```
warning: (BOARD_SPECIFIC_OPTIONS) selects CONSOLE_POST which has unmet
direct dependencies (VENDOR_SIEMENS && BOARD_SIEMENS_MC_BDX1 || !NO_POST)
```
This is currently done for Intel Camelback Mountain and Siemens MC-BDX1.
Selecting the option `CONSOLE_POST` in board specific configuration is
not a good idea, as this should be user configurable over Kconfig, and
also the tree-wide defaults should be the same for these options.
Kconfig is different, as commit 97535558f1 (mainboard/{google,intel}:
Change config option selection) only touch the Intel board.
Change-Id: I91c1e0cb92ed218b6bbc7c33759b91f748cf6f51
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/18878
Tested-by: build bot (Jenkins)
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
| -rw-r--r-- | src/mainboard/intel/camelbackmountain_fsp/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/siemens/mc_bdx1/Kconfig | 4 |
2 files changed, 0 insertions, 5 deletions
diff --git a/src/mainboard/intel/camelbackmountain_fsp/Kconfig b/src/mainboard/intel/camelbackmountain_fsp/Kconfig index 9e71a088f2..3d29e2e3c4 100644 --- a/src/mainboard/intel/camelbackmountain_fsp/Kconfig +++ b/src/mainboard/intel/camelbackmountain_fsp/Kconfig @@ -10,7 +10,6 @@ config BOARD_SPECIFIC_OPTIONS select INTEGRATED_UART if FSP_PACKAGE_DEFAULT select HAVE_FSP_BIN if FSP_PACKAGE_DEFAULT select SERIRQ_CONTINUOUS_MODE - select CONSOLE_POST config MAINBOARD_DIR string diff --git a/src/mainboard/siemens/mc_bdx1/Kconfig b/src/mainboard/siemens/mc_bdx1/Kconfig index e679eb590d..f64b22bf09 100644 --- a/src/mainboard/siemens/mc_bdx1/Kconfig +++ b/src/mainboard/siemens/mc_bdx1/Kconfig @@ -38,10 +38,6 @@ config VIRTUAL_ROM_SIZE hex default 0x1000000 -config CONSOLE_POST - bool - default y - config INTEGRATED_UART bool default n |