summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaweł Anikiel <panikiel@google.com>2023-10-16 14:34:06 +0000
committerJakub Czapiga <czapiga@google.com>2023-10-24 11:32:18 +0000
commit97cd5bdeae3ae95010d0c2437e761777e4fd617d (patch)
tree2b7706f174d5697152bc4c76b7f517f8e9022467
parent41ce3a57d67429066a4f242fd57e64d5ea8dcdec (diff)
mb/google/brya: Set WWAN_PCIE_WAKE_ODL as interrupt on Redrix
This signal gets deasserted by the WWAN modem to reactivate the PCIe link when in low power mode. In order to handle this efficiently, the kernel needs to set up an interrupt. BUG=b:301150499 TEST=Compiled and tested on google/redrix Signed-off-by: Paweł Anikiel <panikiel@google.com> Change-Id: I37f6836aefe4a374eaff3e4bc11358be274cf563 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78416 Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
-rw-r--r--src/mainboard/google/brya/variants/baseboard/brya/gpio.c2
-rw-r--r--src/mainboard/google/brya/variants/redrix/overridetree.cb2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
index 4883a0747f..07f8dbddd1 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
+++ b/src/mainboard/google/brya/variants/baseboard/brya/gpio.c
@@ -19,7 +19,7 @@ static const struct pad_config gpio_table[] = {
/* A6 : ESPI_ALERT1# ==> SPKR_INT_L */
PAD_CFG_GPI(GPP_A6, NONE, DEEP),
/* A7 : SRCCLK_OE7# ==> WWAN_PCIE_WAKE_ODL */
- PAD_CFG_GPI_APIC(GPP_A7, NONE, PLTRST, LEVEL, INVERT),
+ PAD_CFG_GPI_INT(GPP_A7, NONE, PLTRST, EDGE_SINGLE),
/* A8 : SRCCLKREQ7# ==> WWAN_RF_DISABLE_ODL */
PAD_CFG_GPO(GPP_A8, 1, DEEP),
/* A9 : ESPI_CLK ==> ESPI_CLK */
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index cc4961a537..f5556f0527 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -238,7 +238,7 @@ chip soc/intel/alderlake
register "fcpo_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_F21)"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E16)"
register "perst_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E0)"
- register "wake_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A7)"
+ register "wake_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPP_A7)"
register "add_acpi_dma_property" = "true"
use rp6_rtd3 as rtd3dev
device generic 0 alias rp6_wwan on