diff options
| author | Lijian Zhao <lijian.zhao@intel.com> | 2021-02-06 12:18:12 +0800 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2021-02-10 07:22:35 +0000 |
| commit | 94e4961a0122df88d51f000dc148d9bd7d05409b (patch) | |
| tree | b8f2688790e7dfd3e4f2c64dc00bf89c0f1c0aee | |
| parent | f7a7e65aa44d5163e27819c5e2050abb93b68cd1 (diff) | |
acpi: Fix Coverity Scan report
Fix the issue that return value "r" in line 534 will get overwritten
problem.
BUG=CID 1445995
TEST=Build sucessful and boot up in QEMU
Signed-off-by: Lijian Zhao <lijian.zhao@intel.com>
Change-Id: Icf760b142cfecfed7c929c15ad190ac74df027b1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50352
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | src/arch/x86/acpi_bert_storage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/arch/x86/acpi_bert_storage.c b/src/arch/x86/acpi_bert_storage.c index f1dcf47c23..b07b67ee8a 100644 --- a/src/arch/x86/acpi_bert_storage.c +++ b/src/arch/x86/acpi_bert_storage.c @@ -534,7 +534,7 @@ acpi_generic_error_status_t *bert_new_event(guid_t *guid) r = bert_append_genproc(status); else if (!guidcmp(guid, &CPER_SEC_PROC_GENERIC_GUID)) r = bert_append_ia32x64(status); - if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID)) + else if (!guidcmp(guid, &CPER_SEC_FW_ERR_REC_REF_GUID)) r = bert_append_fw_err(status); /* else if other types not implemented */ else |