summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2017-12-14 18:03:45 -0800
committerMartin Roth <martinroth@google.com>2017-12-20 16:43:04 +0000
commit916fc80b69a5273fd9c8ddb1a2dd403840ce6af2 (patch)
tree94ff3ff6efacdb2e925720063a0581035e8b9e21
parent2d26a369102c120d5174aba63df610f5703b4f06 (diff)
google/gru: Prettify strapping ID ADC table
This patch shifts some comments around to make it easier to replace values in the ADC strapping bucket table with compile-time conditionals. Change-Id: Ic51917d3961a51d4e725ff824fb59aeefe149855 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/22890 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: David Schneider <dnschneid@chromium.org> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/mainboard/google/gru/boardid.c43
1 files changed, 20 insertions, 23 deletions
diff --git a/src/mainboard/google/gru/boardid.c b/src/mainboard/google/gru/boardid.c
index af56f1d66a..6d186480b1 100644
--- a/src/mainboard/google/gru/boardid.c
+++ b/src/mainboard/google/gru/boardid.c
@@ -19,29 +19,26 @@
#include <stdlib.h>
#include <soc/saradc.h>
-/*
- * ID info:
- * ID : Volts : ADC value : Bucket
- * == ===== ========= ===========
- * 0 : 0.074V: 42 : 0 - 81
- * 1 : 0.211V: 120 : 82 - 150
- * 2 : 0.319V: 181 : 151 - 211
- * 3 : 0.427V: 242 : 212 - 274
- * 4 : 0.542V: 307 : 275 - 342
- * 5 : 0.666V: 378 : 343 - 411
- * 6 : 0.781V: 444 : 412 - 477
- * 7 : 0.900V: 511 : 478 - 545
- * 8 : 1.023V: 581 : 546 - 613
- * 9 : 1.137V: 646 : 614 - 675
- * 10 : 1.240V: 704 : 676 - 733
- * 11 : 1.343V: 763 : 734 - 795
- * 12 : 1.457V: 828 : 796 - 861
- * 13 : 1.576V: 895 : 862 - 925
- * 14 : 1.684V: 956 : 926 - 989
- * 15 : 1.800V: 1023 : 990 - 1023
- */
-static const int id_readings[] = { 81, 150, 211, 274, 342, 411, 477, 545,
- 613, 675, 733, 795, 861, 925, 989, 1023 };
+static const int id_readings[] = {
+/* ID : Volts : ADC value : Bucket */
+/* == ===== ========= ========== */
+/* 0 : 0.074V: 42 : 0 - 81 */ 81,
+/* 1 : 0.211V: 120 : 82 - 150 */ 150,
+/* 2 : 0.319V: 181 : 151 - 211 */ 211,
+/* 3 : 0.427V: 242 : 212 - 274 */ 274,
+/* 4 : 0.542V: 307 : 275 - 342 */ 342,
+/* 5 : 0.666V: 378 : 343 - 411 */ 411,
+/* 6 : 0.781V: 444 : 412 - 477 */ 477,
+/* 7 : 0.900V: 511 : 478 - 545 */ 545,
+/* 8 : 1.023V: 581 : 546 - 613 */ 613,
+/* 9 : 1.137V: 646 : 614 - 675 */ 675,
+/* 10 : 1.240V: 704 : 676 - 733 */ 733,
+/* 11 : 1.343V: 763 : 734 - 795 */ 795,
+/* 12 : 1.457V: 828 : 796 - 861 */ 861,
+/* 13 : 1.576V: 895 : 862 - 925 */ 925,
+/* 14 : 1.684V: 956 : 926 - 989 */ 989,
+/* 15 : 1.800V: 1023 : 990 - 1023 */ 1023
+};
_Static_assert(ARRAY_SIZE(id_readings) == 16, "Yo' messed up da table, bruh!");
static int cached_board_id = -1;
static int cached_ram_id = -1;