summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@google.com>2023-04-25 16:52:54 -0600
committerKarthik Ramasubramanian <kramasub@google.com>2023-05-02 21:43:52 +0000
commit8d3ca33d15313a03ea0793e8f38f3e4e1c4ce10e (patch)
tree474a5c54dd8a333305304aac19fa0f1159835486
parent7803190d9e8c2f17edbb1e6174a3b2c29b92a260 (diff)
mb/google/myst: Inject SPD binaries to APCB
Add rules to inject the variant specific SPD binaries into APCB. BUG=b:273383819 TEST=Build Myst BIOS image. Currently no APCB is present. So no SPD is injected into APCB. Change-Id: Ic511cdc4fe0989c9abc0cd0531cc0cae40f8dc34 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74746 Reviewed-by: Tim Van Patten <timvp@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com> Reviewed-by: Jon Murphy <jpmurphy@google.com>
-rw-r--r--src/mainboard/google/myst/Makefile.inc27
1 files changed, 27 insertions, 0 deletions
diff --git a/src/mainboard/google/myst/Makefile.inc b/src/mainboard/google/myst/Makefile.inc
index 418ff9ec3e..136966e550 100644
--- a/src/mainboard/google/myst/Makefile.inc
+++ b/src/mainboard/google/myst/Makefile.inc
@@ -14,3 +14,30 @@ subdirs-y += variants/$(VARIANT_DIR)
CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/include
+
+APCB_NAME=APCB_PHX_D5
+
+ifneq ($(wildcard $(MAINBOARD_BLOBS_DIR)/$(APCB_NAME).bin),)
+$(info APCB sources present.)
+
+ifneq ($(wildcard $(src)/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/memory/Makefile.inc),)
+
+LIB_SPD_DEPS = $(SPD_SOURCES)
+
+APCB_SOURCES = $(obj)/$(APCB_NAME).gen
+
+$(obj)/$(APCB_NAME).gen: $(SPD_SOURCES) \
+ $(APCB_V3_EDIT_TOOL) \
+ $(MAINBOARD_BLOBS_DIR)/$(APCB_NAME).bin
+ $(APCB_V3_EDIT_TOOL) $(MAINBOARD_BLOBS_DIR)/$(APCB_NAME).bin \
+ $(obj)/$(APCB_NAME).gen \
+ --spd_sources $(SPD_SOURCES) \
+ --mem_type 'lp5'
+else
+$(info SPD sources not found. Skipping APCB.)
+files_added:: die_no_apcb
+endif
+else
+$(info APCB sources not found. Skipping APCB.)
+files_added:: warn_no_apcb
+endif