diff options
| author | Martin Roth <gaumless@gmail.com> | 2024-04-11 20:54:05 -0600 |
|---|---|---|
| committer | Felix Singer <service+coreboot-gerrit@felixsinger.de> | 2024-04-20 21:08:36 +0000 |
| commit | 8b53aa6eee3bf82b9bde323eca32fbab88983c1a (patch) | |
| tree | 48f006bf3cf30a23324d374547ca2e06389326ae | |
| parent | 63ca402088883a3b89adea1ccd40045dbd4895c1 (diff) | |
util/lint: Add lint rule to watch for Makefile.inc
This should keep new makefiles from being named Makefile.inc.
Change-Id: I4a47998e1c997b82b8a15319eae96cdc0de64e77
Signed-off-by: Martin Roth <gaumless@gmail.com>
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81857
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
| -rwxr-xr-x | util/lint/lint-stable-030-makefile-inc | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/util/lint/lint-stable-030-makefile-inc b/util/lint/lint-stable-030-makefile-inc new file mode 100755 index 0000000000..a586bea91f --- /dev/null +++ b/util/lint/lint-stable-030-makefile-inc @@ -0,0 +1,24 @@ +#!/usr/bin/env sh +# SPDX-License-Identifier: GPL-2.0-or-later +# +# DESCR: Verify that Makefiles are not named Makefile.inc +# + +LINTDIR="$( + cd -- "$(dirname "$0")" > /dev/null 2>&1 || return + pwd -P +)" + +# shellcheck source=helper_functions.sh +. "${LINTDIR}/helper_functions.sh" + +# Exit if the code isn't in a git repo +if [ "${IN_GIT_TREE}" -eq 0 ]; then + exit 0 +fi + +MAKELIST="$(${FIND_FILES} | grep Makefile.inc)" +if [ -n "${MAKELIST}" ]; then + echo "Error: Makefiles should be Makefile.mk not Makefile.inc" + echo "${MAKELIST}" +fi |