summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-01-28 04:17:40 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-01-31 17:36:15 +0000
commit7c26960cbd3979bf080cbf338a55ce4fd4949f28 (patch)
treed09ad8425d22d1aa92db3838eceb3fc7b5fbf756
parentc3fec864b658ae26ff3518b523ed02f8bc1cae29 (diff)
soc/amd/mendocino/acpi: use acpigen_write_processor_device
Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I036dcddf89e8d865d0dc3ef0bd9e48842d8bf6c3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72492 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
-rw-r--r--src/soc/amd/mendocino/acpi.c19
1 files changed, 4 insertions, 15 deletions
diff --git a/src/soc/amd/mendocino/acpi.c b/src/soc/amd/mendocino/acpi.c
index d30fb85cec..6b20b023d5 100644
--- a/src/soc/amd/mendocino/acpi.c
+++ b/src/soc/amd/mendocino/acpi.c
@@ -231,10 +231,10 @@ static size_t get_pstate_info(struct acpi_sw_pstate *pstate_values,
void generate_cpu_entries(const struct device *device)
{
int logical_cores;
- size_t pstate_count, cpu, proc_blk_len;
+ size_t pstate_count, cpu;
struct acpi_sw_pstate pstate_values[MAX_PSTATES] = { {0} };
struct acpi_xpss_sw_pstate pstate_xpss_values[MAX_PSTATES] = { {0} };
- uint32_t threads_per_core, proc_blk_addr;
+ uint32_t threads_per_core;
uint32_t cstate_base_address =
rdmsr(MSR_CSTATE_ADDRESS).lo & MSR_CSTATE_ADDRESS_MASK;
@@ -295,18 +295,7 @@ void generate_cpu_entries(const struct device *device)
logical_cores = get_cpu_count();
for (cpu = 0; cpu < logical_cores; cpu++) {
-
- if (cpu == 0) {
- /* BSP values for \_SB.Pxxx */
- proc_blk_len = 6;
- proc_blk_addr = ACPI_GPE0_BLK;
- } else {
- /* AP values for \_SB.Pxxx */
- proc_blk_addr = 0;
- proc_blk_len = 0;
- }
-
- acpigen_write_processor(cpu, proc_blk_addr, proc_blk_len);
+ acpigen_write_processor_device(cpu);
acpigen_write_pct_package(&perf_ctrl, &perf_sts);
@@ -329,7 +318,7 @@ void generate_cpu_entries(const struct device *device)
generate_cppc_entries(cpu);
- acpigen_pop_len();
+ acpigen_write_processor_device_end();
}
acpigen_write_processor_package("PPKG", 0, logical_cores);