diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-12-17 11:37:20 +0100 |
|---|---|---|
| committer | Hung-Te Lin <hungte@chromium.org> | 2020-12-24 08:16:53 +0000 |
| commit | 707e03d8b90cf8a25520b7c5db4fa76d3a276f6a (patch) | |
| tree | 4366809f684e86b84642ab9cac52b795c4373052 | |
| parent | 3e4f4e0229626c02e6bb261eb2251fbc7c05ad55 (diff) | |
mb/prodrive/hermes: Use already-defined SMBus macros
Drop chipset register definitions in mainboard code in favor of existing
definitions in a header. These definitions are not mainboard-specific.
Tested with BUILD_TIMELESS=1, Prodrive Hermes remains identical.
Change-Id: I29d6f35ec27bff43cf52ae697e905b6a7b48a8d1
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48805
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
| -rw-r--r-- | src/mainboard/prodrive/hermes/eeprom.c | 3 | ||||
| -rw-r--r-- | src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/mainboard/prodrive/hermes/eeprom.c b/src/mainboard/prodrive/hermes/eeprom.c index 25fde349e6..cece32cf55 100644 --- a/src/mainboard/prodrive/hermes/eeprom.c +++ b/src/mainboard/prodrive/hermes/eeprom.c @@ -3,6 +3,7 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/smbus_host.h> +#include <soc/intel/common/block/smbus/smbuslib.h> #include "variants/baseboard/include/eeprom.h" /* @@ -32,7 +33,7 @@ bool read_write_config(u8 addr, void *blob, size_t read_offset, size_t write_off int ret = 0; u32 smb_ctrl_reg = pci_read_config32(PCH_DEV_SMBUS, HOSTC); - pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | HOSTC_I2C_EN); + pci_write_config32(PCH_DEV_SMBUS, HOSTC, smb_ctrl_reg | I2C_EN); printk(BIOS_SPEW, "%s\tOffset: %04zx\tSize: %02zx\n", __func__, read_offset, size); diff --git a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h index 85edbcf903..bdfce8a278 100644 --- a/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h +++ b/src/mainboard/prodrive/hermes/variants/baseboard/include/eeprom.h @@ -2,9 +2,6 @@ #include <soc/ramstage.h> -#define HOSTC 0x40 -#define SMBUS_IO_BASE 0xefa0 -#define HOSTC_I2C_EN (1 << 2) #define I2C_ADDR_EEPROM 0x57 #if ENV_ROMSTAGE |