summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-02-04 17:23:04 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-02-05 18:59:11 +0000
commit6c170e6b3cd5e389a29a11f6755d54615d130ec0 (patch)
tree841876538c94200c48224be3f63e2a6fd749b702
parente5592d3d99af72be58d8392d7957be8cd9632e7c (diff)
soc/amd/common/include/acpimmio: drop 16 and 32 bit PM2 access functions
The PM2 ACPIMMIO region should only be accessed with 8 bit accesses. Using 16 or 32 bit read accesses will return the data from the first byte for all 2 or 4 bytes and 16 or 32 bit write accesses will result in only the first byte being written which is both unexpected behavior. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I5ace50d3b81b5bf3ea3b10aa02f25c58a6ea99b9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61625 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
-rw-r--r--src/soc/amd/common/block/include/amdblocks/acpimmio.h20
1 files changed, 0 insertions, 20 deletions
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index ae8673045d..2d632f606a 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -198,31 +198,11 @@ static inline uint8_t pm2_read8(uint8_t reg)
return read8(acpimmio_pmio2 + reg);
}
-static inline uint16_t pm2_read16(uint8_t reg)
-{
- return read16(acpimmio_pmio2 + reg);
-}
-
-static inline uint32_t pm2_read32(uint8_t reg)
-{
- return read32(acpimmio_pmio2 + reg);
-}
-
static inline void pm2_write8(uint8_t reg, uint8_t value)
{
write8(acpimmio_pmio2 + reg, value);
}
-static inline void pm2_write16(uint8_t reg, uint16_t value)
-{
- write16(acpimmio_pmio2 + reg, value);
-}
-
-static inline void pm2_write32(uint8_t reg, uint32_t value)
-{
- write32(acpimmio_pmio2 + reg, value);
-}
-
static inline uint8_t acpi_read8(uint8_t reg)
{
return read8(acpimmio_acpi + reg);