diff options
| author | Martin Roth <gaumless@gmail.com> | 2023-03-20 10:59:04 -0600 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-03-21 19:09:21 +0000 |
| commit | 6bbf16d5d29b05f86d4f21d43471c803db96328e (patch) | |
| tree | 72f0e64a9e3ccf0ed67f16580814ec7bc4af6a56 | |
| parent | c5c7fa494b881eb837248e35ffc888a5978c556b (diff) | |
mb/google/skyrim: Delete PSPP TODO
Because Mendocino doesn't support PCIe Gen4, PSPP on this platform does
not save any power, so leave it disabled.
BUG=273889287
TEST=None
BRANCH=skyrim
Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I1a1c6692cd0a44469a35582042b92eeec31073fa
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73826
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/mainboard/google/skyrim/variants/baseboard/devicetree.cb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index 6892742050..202ab265ba 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -79,7 +79,8 @@ chip soc/amd/mendocino register "gpp_clk_config[2]" = "GPP_CLK_REQ" register "gpp_clk_config[3]" = "GPP_CLK_OFF" - register "pspp_policy" = "DXIO_PSPP_DISABLED" # TODO: reenable when PSPP works + # PSPP doesn't save any power on this platform + register "pspp_policy" = "DXIO_PSPP_DISABLED" register "s0ix_enable" = "true" |