diff options
| author | Nico Huber <nico.h@gmx.de> | 2024-07-30 12:06:38 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2024-08-08 20:16:25 +0000 |
| commit | 6b8c40a95a4475473ce4e772dbaa6d87863cf874 (patch) | |
| tree | 9e11325bbb89652dfd33ee594616a07abf165108 | |
| parent | 490e7c3f92eaed4455ff9b2e37255bcf52e0e831 (diff) | |
Makefile: Move `--no-warn-rwx-segments' into xcompile
The parameter is not available for binutils older than 2.39. So move it
to xcompile to provide backwards compatibility for a bit.
Change-Id: I02982769ae2c356f037a747e85d155368bfcb730
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83693
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
| -rw-r--r-- | Makefile.mk | 3 | ||||
| -rwxr-xr-x | util/xcompile/xcompile | 6 |
2 files changed, 6 insertions, 3 deletions
diff --git a/Makefile.mk b/Makefile.mk index e9ad2ccbb2..901d6b29c6 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -604,9 +604,6 @@ LDFLAGS_common += -nostdlib LDFLAGS_common += --nmagic LDFLAGS_common += -static LDFLAGS_common += -z noexecstack -# Disable warning on segments with RWX. -# All loadable sections are placed in the same segment for simplicity. -LDFLAGS_common += --no-warn-rwx-segments # Workaround for RISC-V linker bug, merge back into above line when fixed. # https://sourceware.org/bugzilla/show_bug.cgi?id=27180 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 4ead648305..13ed48be52 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -241,6 +241,12 @@ detect_special_flags() { testcc "$GCC" "$CFLAGS_GCC -Wextra" && CFLAGS_GCC="$CFLAGS_GCC -Wextra" + # Disable warning on segments with RWX. + # All loadable sections are placed in the same segment for simplicity. + testld "$GCC" "$FLAGS_GCC" "${GCCPREFIX}ld${LINKER_SUFFIX}" \ + "$LDFLAGS --no-warn-rwx-segments" && \ + LDFLAGS="$LDFLAGS --no-warn-rwx-segments" + case "$architecture" in x86) ;; |