summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2023-05-08 19:25:13 +0200
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2023-09-21 21:06:02 +0000
commit627b0332c03973174687e19eab6e6eb8fe308a63 (patch)
treea6a5b7a211c45bb8d8ec5f2ea9162941191c5da4
parent88ab310b62185acc2c1aa35085ff31f881349ac1 (diff)
mb/google/oak: Move Selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: Idf4a566af3853636945709c88c03fb8e777211c2 Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75014 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin L Roth <gaumless@gmail.com>
-rw-r--r--src/mainboard/google/oak/Kconfig9
-rw-r--r--src/mainboard/google/oak/Kconfig.name3
2 files changed, 9 insertions, 3 deletions
diff --git a/src/mainboard/google/oak/Kconfig b/src/mainboard/google/oak/Kconfig
index 03535e95e5..7db0d44e13 100644
--- a/src/mainboard/google/oak/Kconfig
+++ b/src/mainboard/google/oak/Kconfig
@@ -3,6 +3,15 @@
config BOARD_GOOGLE_OAK_COMMON
def_bool n
+config BOARD_GOOGLE_OAK
+ select BOARD_GOOGLE_OAK_COMMON
+
+config BOARD_GOOGLE_ELM
+ select BOARD_GOOGLE_OAK_COMMON
+
+config BOARD_GOOGLE_HANA
+ select BOARD_GOOGLE_OAK_COMMON
+
if BOARD_GOOGLE_OAK_COMMON
config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/google/oak/Kconfig.name b/src/mainboard/google/oak/Kconfig.name
index 7353ddab43..cb9ff14942 100644
--- a/src/mainboard/google/oak/Kconfig.name
+++ b/src/mainboard/google/oak/Kconfig.name
@@ -2,12 +2,9 @@ comment "Oak"
config BOARD_GOOGLE_OAK
bool "-> Oak"
- select BOARD_GOOGLE_OAK_COMMON
config BOARD_GOOGLE_ELM
bool "-> Elm (Acer Chromebook R13)"
- select BOARD_GOOGLE_OAK_COMMON
config BOARD_GOOGLE_HANA
bool "-> Hana (Lenovo N23 Yoga Chromebook)"
- select BOARD_GOOGLE_OAK_COMMON