summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Rhodes <sean@starlabs.systems>2021-12-19 21:22:15 +0000
committerFelix Held <felix-coreboot@felixheld.de>2022-01-04 11:52:10 +0000
commit58f6a5d7445c0215358b429a0a3b8a8f18097e46 (patch)
tree52791c5c25c13954cda75d7f8a0eb29a637b7f5e
parent187bec7ac03f6a19a732964616e85d7785317935 (diff)
starlabs: Convert EC_GPE_SCI to Kconfig
Convert EC_GPI_SCI to Kconfig option with default value of 0x50 that is used by most boards. Signed-off-by: Sean Rhodes <sean@starlabs.systems> Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 Reviewed-on: https://review.coreboot.org/c/coreboot/+/60229 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/ec/starlabs/merlin/Kconfig4
-rw-r--r--src/ec/starlabs/merlin/acpi/ec.asl2
-rw-r--r--src/mainboard/starlabs/labtop/Kconfig4
-rw-r--r--src/mainboard/starlabs/labtop/dsdt.asl2
4 files changed, 9 insertions, 3 deletions
diff --git a/src/ec/starlabs/merlin/Kconfig b/src/ec/starlabs/merlin/Kconfig
index fe94b85963..67582ac4a7 100644
--- a/src/ec/starlabs/merlin/Kconfig
+++ b/src/ec/starlabs/merlin/Kconfig
@@ -55,3 +55,7 @@ config EC_STARLABS_MERLIN
config EC_VARIANT_DIR
string
default "merlin" if EC_STARLABS_MERLIN
+
+config EC_GPE_SCI
+ hex
+ default 0x50
diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl
index 2c2b8d7f3a..c540c03d7a 100644
--- a/src/ec/starlabs/merlin/acpi/ec.asl
+++ b/src/ec/starlabs/merlin/acpi/ec.asl
@@ -10,7 +10,7 @@ Scope (\_SB.PCI0.LPCB)
{
Name (_HID, EisaId ("PNP0C09"))
Name (_UID, 0x01)
- Name (_GPE, EC_GPE_SCI)
+ Name (_GPE, CONFIG_EC_GPE_SCI)
Name (ECAV, 0x00)
Name (ECTK, 0x01)
Name (B2ST, 0x00)
diff --git a/src/mainboard/starlabs/labtop/Kconfig b/src/mainboard/starlabs/labtop/Kconfig
index 9d74d2b934..e133faab3f 100644
--- a/src/mainboard/starlabs/labtop/Kconfig
+++ b/src/mainboard/starlabs/labtop/Kconfig
@@ -40,6 +40,10 @@ config DIMM_SPD_SIZE
config DRIVER_TPM_SPI_CHIP
default 2
+config EC_GPE_SCI
+ default 0x6e if BOARD_STARLABS_STARBOOK_TGL
+ default 0x50
+
config EC_STARLABS_ADD_ITE_BIN
default y
diff --git a/src/mainboard/starlabs/labtop/dsdt.asl b/src/mainboard/starlabs/labtop/dsdt.asl
index ebb3de37b5..ac6bc433de 100644
--- a/src/mainboard/starlabs/labtop/dsdt.asl
+++ b/src/mainboard/starlabs/labtop/dsdt.asl
@@ -1,7 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#define EC_GPE_SCI 0x6e
-
#include <acpi/acpi.h>
DefinitionBlock(
"dsdt.aml",