summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Hui <buurin@gmail.com>2020-04-30 21:30:36 -0400
committerPatrick Georgi <pgeorgi@google.com>2020-05-04 09:40:05 +0000
commit576315e1bec889a76ec14875a4e8037495cc173e (patch)
tree1f79dd335c9543c15d5825dbae3afea3b6d7af47
parent0e0fdbef1cc7753b836321aa72f4bb71613d124e (diff)
asus/p2b: Enable IDE and UDMA for all variants
There's no reason not to. Change-Id: I12c9e0f66c437d8add5c4096fd2a5e747d082799 Signed-off-by: Keith Hui <buurin@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40961 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rw-r--r--src/mainboard/asus/p2b/devicetree.cb8
-rw-r--r--src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb8
-rw-r--r--src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb8
3 files changed, 4 insertions, 20 deletions
diff --git a/src/mainboard/asus/p2b/devicetree.cb b/src/mainboard/asus/p2b/devicetree.cb
index 9dcd1da1db..9f7f63e5f3 100644
--- a/src/mainboard/asus/p2b/devicetree.cb
+++ b/src/mainboard/asus/p2b/devicetree.cb
@@ -46,10 +46,10 @@ chip northbridge/intel/i440bx # Northbridge
register "ide1_enable" = "1"
register "ide_legacy_enable" = "1"
# Enable UDMA/33 for higher speed if your IDE device(s) support it.
- register "ide0_drive0_udma33_enable" = "0"
- register "ide0_drive1_udma33_enable" = "0"
- register "ide1_drive0_udma33_enable" = "0"
- register "ide1_drive1_udma33_enable" = "0"
+ register "ide0_drive0_udma33_enable" = "1"
+ register "ide0_drive1_udma33_enable" = "1"
+ register "ide1_drive0_udma33_enable" = "1"
+ register "ide1_drive1_udma33_enable" = "1"
register "thrm_polarity" = "1"
register "lid_polarity" = "1"
end
diff --git a/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb
index 742414411b..ce36ce60d0 100644
--- a/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb
+++ b/src/mainboard/asus/p2b/variants/p2b-d/overridetree.cb
@@ -17,14 +17,6 @@ chip northbridge/intel/i440bx # Northbridge
end
end
end
- register "ide0_enable" = "1"
- register "ide1_enable" = "1"
- register "ide_legacy_enable" = "1"
- # Enable UDMA/33 for higher speed if your IDE device(s) support it.
- register "ide0_drive0_udma33_enable" = "1"
- register "ide0_drive1_udma33_enable" = "1"
- register "ide1_drive0_udma33_enable" = "1"
- register "ide1_drive1_udma33_enable" = "1"
end
end
end
diff --git a/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb b/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb
index 6eabe5897b..b261a3514f 100644
--- a/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb
+++ b/src/mainboard/asus/p2b/variants/p2b-ds/overridetree.cb
@@ -18,14 +18,6 @@ chip northbridge/intel/i440bx # Northbridge
end
end
device pci 6.0 on end # Onboard SCSI
- register "ide0_enable" = "1"
- register "ide1_enable" = "1"
- register "ide_legacy_enable" = "1"
- # Enable UDMA/33 for higher speed if your IDE device(s) support it.
- register "ide0_drive0_udma33_enable" = "1"
- register "ide0_drive1_udma33_enable" = "1"
- register "ide1_drive0_udma33_enable" = "1"
- register "ide1_drive1_udma33_enable" = "1"
end
end
end