summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichał Kopeć <michal.kopec@3mdeb.com>2022-02-22 12:28:33 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-03-07 17:51:07 +0000
commit45037f786c1732e318d1c56e62e5f6b3fe947971 (patch)
treec59d48fb1f4bd36a9d197aa955f129e78ae7c1d5
parentc3dab9c427988adeec3b242d59b5ee1997f67092 (diff)
soc/intel/tigerlake: Hide PMC and IOM devices
Windows complains on missing drivers for these ACPI devices. Hide them from OS as it doesn't influence the hardware operation. Linux can still probe the drivers correctly. TEST=Boot Windows 11 and see there are no devices with missing drivers. Boot Ubuntu 20.04 and check that drivers corresponding to ACPI HIDs are still probed. Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> Change-Id: I6c30c08ab730749bddef7ea67c7470c1554bd572 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62492 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
-rw-r--r--src/soc/intel/tigerlake/acpi/tcss.asl2
-rw-r--r--src/soc/intel/tigerlake/pmc.c2
2 files changed, 4 insertions, 0 deletions
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl
index 1d58bfb520..50307f4db7 100644
--- a/src/soc/intel/tigerlake/acpi/tcss.asl
+++ b/src/soc/intel/tigerlake/acpi/tcss.asl
@@ -336,6 +336,8 @@ Scope (\_SB.PCI0)
Name (_CRS, ResourceTemplate () {
Memory32Fixed (ReadWrite, IOM_BASE_ADDRESS, IOM_BASE_SIZE)
})
+ /* Hide the device so that Windows does not complain on missing driver */
+ Name (_STA, 0xB)
}
/*
diff --git a/src/soc/intel/tigerlake/pmc.c b/src/soc/intel/tigerlake/pmc.c
index 937943a029..b8eb3078c4 100644
--- a/src/soc/intel/tigerlake/pmc.c
+++ b/src/soc/intel/tigerlake/pmc.c
@@ -106,6 +106,8 @@ static void soc_pmc_fill_ssdt(const struct device *dev)
acpigen_write_name_string("_HID", PMC_HID);
acpigen_write_name_string("_DDN", "Intel(R) Tiger Lake IPC Controller");
+ /* Hide the device so that Windows does not complain on missing driver */
+ acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON);
/*
* Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF).