diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2020-11-23 16:08:54 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-11-30 08:00:19 +0000 |
| commit | 41220cd2453b232759aeb7aa7694e9139ede7a50 (patch) | |
| tree | 4edabfadecda7d0926725f8106c0a342345ff774 | |
| parent | 870e44a7b91a5db34123591d2cb99f491a0cb3b1 (diff) | |
soc/amd/common: add comments and FIXME to Makefile.inc files
Change-Id: Ie347ee508acd900353467b4a3e0a5d1928b110e1
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47877
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/amd/common/block/pci/Makefile.inc | 2 | ||||
| -rw-r--r-- | src/soc/amd/common/block/pi/Makefile.inc | 2 | ||||
| -rw-r--r-- | src/soc/amd/common/block/s3/Makefile.inc | 2 | ||||
| -rw-r--r-- | src/soc/amd/common/block/smbus/Makefile.inc | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/amd/common/block/pci/Makefile.inc b/src/soc/amd/common/block/pci/Makefile.inc index baebb6c33f..1fed96e45a 100644 --- a/src/soc/amd/common/block/pci/Makefile.inc +++ b/src/soc/amd/common/block/pci/Makefile.inc @@ -1,6 +1,6 @@ - ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_PCI) += amd_pci_util.c +# FIXME: This gets added when CONFIG_SOC_AMD_COMMON is set, which is a bit unexpected. bootblock-y += amd_pci_mmconf.c verstage_x86-y += amd_pci_mmconf.c romstage-y += amd_pci_mmconf.c diff --git a/src/soc/amd/common/block/pi/Makefile.inc b/src/soc/amd/common/block/pi/Makefile.inc index 5afbb3ebdb..7b5d73af9c 100644 --- a/src/soc/amd/common/block/pi/Makefile.inc +++ b/src/soc/amd/common/block/pi/Makefile.inc @@ -14,4 +14,4 @@ ramstage-y += heapmanager.c ramstage-y += image.c ramstage-y += refcode_loader.c -endif +endif # CONFIG_SOC_AMD_COMMON_BLOCK_PI diff --git a/src/soc/amd/common/block/s3/Makefile.inc b/src/soc/amd/common/block/s3/Makefile.inc index 9efc6bc414..03395eca9c 100644 --- a/src/soc/amd/common/block/s3/Makefile.inc +++ b/src/soc/amd/common/block/s3/Makefile.inc @@ -3,4 +3,4 @@ ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_S3),y) romstage-y += s3_resume.c ramstage-y += s3_resume.c -endif +endif # CONFIG_SOC_AMD_COMMON_BLOCK_S3 diff --git a/src/soc/amd/common/block/smbus/Makefile.inc b/src/soc/amd/common/block/smbus/Makefile.inc index cfc954ec4f..b9c7f2a51f 100644 --- a/src/soc/amd/common/block/smbus/Makefile.inc +++ b/src/soc/amd/common/block/smbus/Makefile.inc @@ -4,4 +4,4 @@ romstage-y += smbus.c ramstage-y += smbus.c ramstage-y += sm.c -endif +endif # CONFIG_SOC_AMD_COMMON_BLOCK_SMBUS |