diff options
| author | Krystian Hebel <krystian.hebel@3mdeb.com> | 2021-02-23 16:37:59 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-08-31 16:45:47 +0000 |
| commit | 40adaf6e7c5966e1e4bec6528d0a24339c10e226 (patch) | |
| tree | 5f4fff8e38525e61ba990b51d1db1cd8c9b93062 | |
| parent | ed9f562ca8f6bda651f159db6e155dfea80257b4 (diff) | |
device/dram/ddr4.c: note that dimm size calculation won't work for 3DS
Change-Id: I52548e544165b4732d9989da6455c8fd77bf99d3
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67185
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
| -rw-r--r-- | src/device/dram/ddr4.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/device/dram/ddr4.c b/src/device/dram/ddr4.c index 53b3d25b07..f8fe8d3a96 100644 --- a/src/device/dram/ddr4.c +++ b/src/device/dram/ddr4.c @@ -248,6 +248,7 @@ int spd_decode_ddr4(struct dimm_attr_ddr4_st *dimm, spd_raw_data spd) dimm->vdd_voltage = 1200; /* calculate size */ + /* FIXME: this is wrong for 3DS devices */ dimm->size_mb = cap_per_die_mbit / 8 * bus_width / sdram_width * dimm->ranks; dimm->ecc_extension = spd[SPD_PRIMARY_SDRAM_WIDTH] & SPD_ECC_8BIT; |