diff options
| author | Subrata Banik <subratabanik@google.com> | 2023-09-07 12:57:42 +0000 |
|---|---|---|
| committer | Jakub Czapiga <jacz@semihalf.com> | 2023-09-08 09:21:35 +0000 |
| commit | 3ff6b2ff9efb4401c54af5a7a8d261601568634e (patch) | |
| tree | 1123ebf9896b63f536d98393f7650c22ffed28e6 | |
| parent | 79503ef515967ffceab7bd2a16a381e6a02c3d30 (diff) | |
mb/google/rex: Require VBOOT_LID_SWITCH for Chromebook design
This patch ensures that platforms with lids, such as Chromebooks, only
select the VBOOT_LID_SWITCH configuration option.
Only samples the LID GPIO if VBOOT_LID_SWITCH config is enabled,
otherwise fake LID is open to avoid shutdown after reaching
depthcharge.
Tested by building and booting Google/Rex with the VBOOT_LID_SWITCH
configuration option enabled, and verifying that google/ovis does not
required VBOOT_LID_SWITCH config.
Change-Id: Ic5123b822a5a7021023319cb08a3f9e5225961ba
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77693
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Jakub Czapiga <jacz@semihalf.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
| -rw-r--r-- | src/mainboard/google/rex/Kconfig | 2 | ||||
| -rw-r--r-- | src/mainboard/google/rex/chromeos.c | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 7d384bdf4c..52f241349a 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -160,7 +160,7 @@ config MEMORY_SOLDERDOWN select HAVE_SPD_IN_CBFS config VBOOT - select VBOOT_LID_SWITCH + select VBOOT_LID_SWITCH if BOARD_GOOGLE_BASEBOARD_REX config UART_FOR_CONSOLE int diff --git a/src/mainboard/google/rex/chromeos.c b/src/mainboard/google/rex/chromeos.c index 217b001a06..5ed041f52b 100644 --- a/src/mainboard/google/rex/chromeos.c +++ b/src/mainboard/google/rex/chromeos.c @@ -9,7 +9,12 @@ void fill_lb_gpios(struct lb_gpios *gpios) { struct lb_gpio chromeos_gpios[] = { +#if CONFIG(VBOOT_LID_SWITCH) {-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, +#else + /* fake LID open to avoid shutdown in depthcharge */ + {-1, ACTIVE_HIGH, 1, "lid"}, +#endif {-1, ACTIVE_HIGH, 0, "power"}, {-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"}, {-1, ACTIVE_HIGH, 0, "EC in RW"}, |