summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2023-11-09 22:23:07 +0100
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2023-11-11 01:13:20 +0000
commit3a36daf87358b46fb7275e3fc981fa56c73a3701 (patch)
tree4691b6cd8d4afd3e165d96016ad565885817797b
parent628becd684b40d5033de9fe45b23e4c8600bef9c (diff)
mb/amd/birman: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I836c35e6bbfa77d536065a4237ef85a170df9fdb Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78974 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin L Roth <gaumless@gmail.com>
-rw-r--r--src/mainboard/amd/birman/Kconfig6
-rw-r--r--src/mainboard/amd/birman/Kconfig.name2
2 files changed, 6 insertions, 2 deletions
diff --git a/src/mainboard/amd/birman/Kconfig b/src/mainboard/amd/birman/Kconfig
index 32967b19c8..235f63e1c1 100644
--- a/src/mainboard/amd/birman/Kconfig
+++ b/src/mainboard/amd/birman/Kconfig
@@ -1,5 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-only
+config BOARD_AMD_BIRMAN_PHOENIX
+ select SOC_AMD_PHOENIX
+
+config BOARD_AMD_BIRMAN_GLINDA
+ select SOC_AMD_GLINDA
+
if BOARD_AMD_BIRMAN_GLINDA || BOARD_AMD_BIRMAN_PHOENIX
config BOARD_SPECIFIC_OPTIONS
diff --git a/src/mainboard/amd/birman/Kconfig.name b/src/mainboard/amd/birman/Kconfig.name
index 33830dd919..c02173c93e 100644
--- a/src/mainboard/amd/birman/Kconfig.name
+++ b/src/mainboard/amd/birman/Kconfig.name
@@ -2,8 +2,6 @@ comment "Birman"
config BOARD_AMD_BIRMAN_PHOENIX
bool "-> Birman for Phoenix SoC"
- select SOC_AMD_PHOENIX
config BOARD_AMD_BIRMAN_GLINDA
bool "-> Birman for Glinda SoC"
- select SOC_AMD_GLINDA