diff options
| author | Duncan Laurie <dlaurie@google.com> | 2019-05-23 14:48:29 -0700 |
|---|---|---|
| committer | Duncan Laurie <dlaurie@chromium.org> | 2019-05-24 16:43:57 +0000 |
| commit | 35f9507b08aa8e062b0a1f87eb25b45694378503 (patch) | |
| tree | 2d19bb5bb433f8fb71af435163bb301ead9614c0 | |
| parent | 3dbfb2bef9cdb97ac6e34a4268cc4a26e6483013 (diff) | |
ec/google/wilco: Fix radio control command
This command is working as written, but it is not actually correct
as to what the format of the command should be. Fix this and add
define the other radios. There is no change in the command send to
the EC.
Change-Id: Ia551b08561b673d27bec2f900d97b746699b30c4
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32973
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
| -rw-r--r-- | src/ec/google/wilco/commands.c | 2 | ||||
| -rw-r--r-- | src/ec/google/wilco/commands.h | 10 |
2 files changed, 10 insertions, 2 deletions
diff --git a/src/ec/google/wilco/commands.c b/src/ec/google/wilco/commands.c index 9d4170f539..626f9ddc2c 100644 --- a/src/ec/google/wilco/commands.c +++ b/src/ec/google/wilco/commands.c @@ -159,7 +159,7 @@ void wilco_ec_power_off(enum ec_power_off_reason reason) int wilco_ec_radio_control(enum ec_radio radio, uint8_t state) { - uint8_t radio_control[3] = { 0, radio, state }; + uint8_t radio_control[3] = { radio, RADIO_WRITE, state }; return wilco_ec_mailbox(WILCO_EC_MSG_DEFAULT, KB_RADIO_CONTROL, radio_control, ARRAY_SIZE(radio_control), diff --git a/src/ec/google/wilco/commands.h b/src/ec/google/wilco/commands.h index 9b7f2e5d07..9a185805af 100644 --- a/src/ec/google/wilco/commands.h +++ b/src/ec/google/wilco/commands.h @@ -80,7 +80,15 @@ enum ec_audio_mute { }; enum ec_radio { - RADIO_WIFI = 0x02, + RADIO_WIFI = 0, + RADIO_WWAN, + RADIO_BT, +}; + +enum ec_radio_action { + RADIO_READ = 1, + RADIO_WRITE, + RADIO_TOGGLE, }; enum ec_camera { |